Skip to content

Commit 52c19aa

Browse files
committed
Addresses more feedback.
1 parent 294a143 commit 52c19aa

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

specification/inference/_types/CommonTypes.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -782,7 +782,7 @@ export class CustomServiceSettings {
782782
* ```
783783
* If the subsequent inference requests come from a search context, the `search` key will be used and the template will be replaced with `do_search`.
784784
* If it comes from the ingest context `do_ingest` is used. If it's a different context that is not specified, the default value will be used. If no default is specified an empty string is used.
785-
* `transition` can be:
785+
* `translation` can be:
786786
* * `classification`
787787
* * `clustering`
788788
* * `ingest`
@@ -795,9 +795,11 @@ export class CustomServiceSettings {
795795
* ```
796796
* "query_parameters":[
797797
* ["param_key", "some_value"],
798-
* ["param_key", "another_value"]
798+
* ["param_key", "another_value"],
799+
* ["other_key", "other_value"]
799800
* ]
800801
* ```
802+
* If the base url is `https://www.elastic.co` it results in: `https://www.elastic.co?param_key=some_value&param_key=another_value&other_key=other_value`.
801803
*/
802804
query_parameters?: UserDefinedValue
803805
/**
@@ -832,7 +834,7 @@ export class CustomRequestParams {
832834
* "request": "{\"input\":${input}}"
833835
* ```
834836
* > info
835-
* > The content string needs to be a single line except using the Kibana console.
837+
* > The content string needs to be a single line except when using the Kibana console.
836838
*/
837839
content: string
838840
}

specification/inference/put_custom/PutCustomRequest.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ import { InferenceChunkingSettings } from '@inference/_types/Services'
3232
*
3333
* The custom service gives more control over how to interact with external inference services that aren't explicitly supported through dedicated integrations.
3434
* The custom service gives you the ability to define the headers, url, query parameters, request body, and secrets.
35-
* The custom service supports the template replacement functionality, which enables you to define a template that can be replaced with the contents of a value that defines that key.
35+
* The custom service supports the template replacement functionality, which enables you to define a template that can be replaced with the value associated with that key.
3636
* Templates are portions of a string that start with `${` and end with `}`.
3737
* The parameters `secret_parameters` and `task_settings` are checked for keys for template replacement. Template replacement is supported in the `request`, `headers`, `url`, and `query_parameters`.
3838
* If the definition (key) is not found for a template, an error message is returned.

0 commit comments

Comments
 (0)