Skip to content

Commit 6a19b67

Browse files
github-actions[bot]DaveCTurnerDiannaHohenseepquentin
authored
Expand docs for include_defaults (#5052) (#5092)
This parameter is trappy, its notion of "default" includes the values from some arbitrary node's `elasticsearch.yml` file which means they aren't really defaults. But then again the real default values would be even less useful in the (common) case that some setting is overridden on all nodes. (cherry picked from commit 4d0434b) Co-authored-by: David Turner <[email protected]> Co-authored-by: Dianna Hohensee <[email protected]> Co-authored-by: Quentin Pradet <[email protected]>
1 parent 17e5777 commit 6a19b67

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

specification/cluster/get_settings/ClusterGetSettingsRequest.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,12 @@ export interface Request extends RequestBase {
4444
*/
4545
flat_settings?: boolean
4646
/**
47-
* If `true`, returns default cluster settings from the local node.
47+
* If `true`, also returns default values for all other cluster settings, reflecting the values
48+
* in the `elasticsearch.yml` file of one of the nodes in the cluster. If the nodes in your
49+
* cluster do not all have the same values in their `elasticsearch.yml` config files then the
50+
* values returned by this API may vary from invocation to invocation and may not reflect the
51+
* values that Elasticsearch uses in all situations. Use the `GET _nodes/settings` API to
52+
* fetch the settings for each individual node in your cluster.
4853
* @server_default false
4954
*/
5055
include_defaults?: boolean

0 commit comments

Comments
 (0)