[8.17] Use min node version to guard injecting settings in logs provider (#123005) (#123051)

* Use min node version to guard injecting settings in logs provider (#123005)

* Use min node version to guard injecting settings in logs provider

* Update docs/changelog/123005.yaml

* no random in cluster init

(cherry picked from commit 5c12978)

# Conflicts:
#	x-pack/plugin/logsdb/src/main/java/org/elasticsearch/xpack/logsdb/LogsDBPlugin.java
#	x-pack/plugin/logsdb/src/main/java/org/elasticsearch/xpack/logsdb/LogsdbIndexModeSettingsProvider.java
#	x-pack/plugin/logsdb/src/test/java/org/elasticsearch/xpack/logsdb/LogsdbIndexModeSettingsProviderTests.java
#	x-pack/plugin/logsdb/src/test/java/org/elasticsearch/xpack/logsdb/SyntheticSourceIndexSettingsProviderLegacyLicenseTests.java

* port fixes

Author: kkrik-es

docs/changelog/123005.yaml

@@ -0,0 +1,6 @@
+pr: 123005
+summary: Use min node version to guard injecting settings in logs provider
+area: Logs
+type: bug
+issues:
+ - 122950

x-pack/plugin/logsdb/src/main/java/org/elasticsearch/xpack/logsdb/LogsDBPlugin.java

@@ -73,7 +73,8 @@ public Collection<IndexSettingProvider> getAdditionalIndexSettingProviders(Index
             () -> IndexVersion.min(
                 IndexVersion.current(),
                 parameters.clusterService().state().nodes().getMaxDataNodeCompatibleIndexVersion()
-            )
+            ),
+            () -> parameters.clusterService().state().nodes().getMinNodeVersion()
         );
         return List.of(syntheticSettingProvider, logsdbIndexModeSettingsProvider);
     }

x-pack/plugin/logsdb/src/main/java/org/elasticsearch/xpack/logsdb/SyntheticSourceIndexSettingsProvider.java

@@ -9,6 +9,7 @@
 
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
+import org.elasticsearch.Version;
 import org.elasticsearch.cluster.metadata.IndexMetadata;
 import org.elasticsearch.cluster.metadata.Metadata;
 import org.elasticsearch.common.UUIDs;
@@ -41,17 +42,20 @@ final class SyntheticSourceIndexSettingsProvider implements IndexSettingProvider
     private final CheckedFunction<IndexMetadata, MapperService, IOException> mapperServiceFactory;
     private final LogsdbIndexModeSettingsProvider logsdbIndexModeSettingsProvider;
     private final Supplier<IndexVersion> createdIndexVersion;
+    private final Supplier<Version> minNodeVersion;
 
     SyntheticSourceIndexSettingsProvider(
         SyntheticSourceLicenseService syntheticSourceLicenseService,
         CheckedFunction<IndexMetadata, MapperService, IOException> mapperServiceFactory,
         LogsdbIndexModeSettingsProvider logsdbIndexModeSettingsProvider,
-        Supplier<IndexVersion> createdIndexVersion
+        Supplier<IndexVersion> createdIndexVersion,
+        Supplier<Version> minNodeVersion
     ) {
         this.syntheticSourceLicenseService = syntheticSourceLicenseService;
         this.mapperServiceFactory = mapperServiceFactory;
         this.logsdbIndexModeSettingsProvider = logsdbIndexModeSettingsProvider;
         this.createdIndexVersion = createdIndexVersion;
+        this.minNodeVersion = minNodeVersion;
     }
 
     @Override
@@ -70,6 +74,10 @@ public Settings getAdditionalIndexSettings(
         Settings indexTemplateAndCreateRequestSettings,
         List<CompressedXContent> combinedTemplateMappings
     ) {
+        if (minNodeVersion.get().before(Version.V_8_17_0)) {
+            return Settings.EMPTY;
+        }
+
         var logsdbSettings = logsdbIndexModeSettingsProvider.getLogsdbModeSetting(dataStreamName, indexTemplateAndCreateRequestSettings);
         if (logsdbSettings != Settings.EMPTY) {
             indexTemplateAndCreateRequestSettings = Settings.builder()

x-pack/plugin/logsdb/src/test/java/org/elasticsearch/xpack/logsdb/SyntheticSourceIndexSettingsProviderLegacyLicenseTests.java

@@ -7,6 +7,7 @@
 
 package org.elasticsearch.xpack.logsdb;
 
+import org.elasticsearch.Version;
 import org.elasticsearch.cluster.metadata.DataStream;
 import org.elasticsearch.common.settings.Settings;
 import org.elasticsearch.index.IndexMode;
@@ -54,7 +55,8 @@ public void setup() throws Exception {
             syntheticSourceLicenseService,
             im -> MapperTestUtils.newMapperService(xContentRegistry(), createTempDir(), im.getSettings(), im.getIndex().getName()),
             getLogsdbIndexModeSettingsProvider(false),
-            IndexVersion::current
+            IndexVersion::current,
+            () -> Version.CURRENT
         );
     }
 
@@ -116,7 +118,8 @@ public void testGetAdditionalIndexSettingsTsdbAfterCutoffDate() throws Exception
             syntheticSourceLicenseService,
             im -> MapperTestUtils.newMapperService(xContentRegistry(), createTempDir(), im.getSettings(), im.getIndex().getName()),
             getLogsdbIndexModeSettingsProvider(false),
-            IndexVersion::current
+            IndexVersion::current,
+            () -> Version.CURRENT
         );
 
         Settings settings = Settings.builder().put(SourceFieldMapper.INDEX_MAPPER_SOURCE_MODE_SETTING.getKey(), "SYNTHETIC").build();

x-pack/plugin/logsdb/src/test/java/org/elasticsearch/xpack/logsdb/SyntheticSourceIndexSettingsProviderTests.java

@@ -7,6 +7,7 @@
 
 package org.elasticsearch.xpack.logsdb;
 
+import org.elasticsearch.Version;
 import org.elasticsearch.cluster.metadata.DataStream;
 import org.elasticsearch.cluster.metadata.DataStreamTestHelper;
 import org.elasticsearch.cluster.metadata.Metadata;
@@ -62,7 +63,7 @@ public void setup() throws Exception {
         provider = new SyntheticSourceIndexSettingsProvider(syntheticSourceLicenseService, im -> {
             newMapperServiceCounter.incrementAndGet();
             return MapperTestUtils.newMapperService(xContentRegistry(), createTempDir(), im.getSettings(), im.getIndex().getName());
-        }, getLogsdbIndexModeSettingsProvider(false), IndexVersion::current);
+        }, getLogsdbIndexModeSettingsProvider(false), IndexVersion::current, () -> Version.CURRENT);
         newMapperServiceCounter.set(0);
     }
 
@@ -275,7 +276,7 @@ public void testNewIndexHasSyntheticSourceUsage_invalidSettings() throws IOExcep
         }
     }
 
-    public void testGetAdditionalIndexSettingsDowngradeFromSyntheticSource() throws IOException {
+    public void testGetAdditionalIndexSettingsDowngradeFromSyntheticSource() {
         String dataStreamName = "logs-app1";
         Metadata.Builder mb = Metadata.builder(
             DataStreamTestHelper.getClusterStateWithDataStreams(
@@ -344,13 +345,47 @@ public void testGetAdditionalIndexSettingsDowngradeFromSyntheticSource() throws
         assertThat(newMapperServiceCounter.get(), equalTo(0));
     }
 
+    public void testGetAdditionalIndexSettingsDowngradeFromSyntheticSourceOldNode() {
+        String dataStreamName = "logs-app1";
+        Metadata.Builder mb = Metadata.builder(
+            DataStreamTestHelper.getClusterStateWithDataStreams(
+                List.of(Tuple.tuple(dataStreamName, 1)),
+                List.of(),
+                Instant.now().toEpochMilli(),
+                builder().build(),
+                1
+            ).getMetadata()
+        );
+        Metadata metadata = mb.build();
+
+        Settings settings = builder().put(SourceFieldMapper.INDEX_MAPPER_SOURCE_MODE_SETTING.getKey(), SourceFieldMapper.Mode.SYNTHETIC)
+            .build();
+
+        syntheticSourceLicenseService.setSyntheticSourceFallback(true);
+        provider = new SyntheticSourceIndexSettingsProvider(syntheticSourceLicenseService, im -> {
+            newMapperServiceCounter.incrementAndGet();
+            return MapperTestUtils.newMapperService(xContentRegistry(), createTempDir(), im.getSettings(), im.getIndex().getName());
+        }, getLogsdbIndexModeSettingsProvider(false), IndexVersion::current, () -> Version.V_8_16_0);
+        var result = provider.getAdditionalIndexSettings(
+            DataStream.getDefaultBackingIndexName(dataStreamName, 2),
+            dataStreamName,
+            null,
+            metadata,
+            Instant.ofEpochMilli(1L),
+            settings,
+            List.of()
+        );
+        assertTrue(result.isEmpty());
+    }
+
     public void testGetAdditionalIndexSettingsDowngradeFromSyntheticSourceFileMatch() throws IOException {
         syntheticSourceLicenseService.setSyntheticSourceFallback(true);
         provider = new SyntheticSourceIndexSettingsProvider(
             syntheticSourceLicenseService,
             im -> MapperTestUtils.newMapperService(xContentRegistry(), createTempDir(), im.getSettings(), im.getIndex().getName()),
             getLogsdbIndexModeSettingsProvider(true),
-            IndexVersion::current
+            IndexVersion::current,
+            () -> Version.CURRENT
         );
         final Settings settings = Settings.EMPTY;