Skip to content

Commit a4fe106

Browse files
authored
Merge pull request #24 from elastic/re-enable-pointer-compression
Revert "disable pointer-compression build"
2 parents 0d390af + 9ed9ab8 commit a4fe106

File tree

1 file changed

+35
-38
lines changed

1 file changed

+35
-38
lines changed

.buildkite/pipeline.yml

Lines changed: 35 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -35,35 +35,33 @@ steps:
3535
machineType: c2-standard-60
3636
timeout_in_minutes: 180 # ideally runs in ~2hr
3737

38-
# See https://github.com/nodejs/node/issues/54531
39-
# - label: Build custom node.js artifacts with pointer compression for x64
40-
# command:
41-
# - scripts/create_build_images.sh
42-
# - scripts/build_nodejs.sh
43-
# - scripts/upload_nodejs_artifacts.sh
44-
# env:
45-
# TARGET_ARCH: amd64
46-
# TARGET_VARIANT: 'pointer-compression'
47-
# agents:
48-
# image: family/kibana-ubuntu-2004
49-
# provider: gcp
50-
# machineType: c2-standard-16
51-
# timeout_in_minutes: 60 # ideally runs in ~30m
38+
- label: Build custom node.js artifacts with pointer compression for x64
39+
command:
40+
- scripts/create_build_images.sh
41+
- scripts/build_nodejs.sh
42+
- scripts/upload_nodejs_artifacts.sh
43+
env:
44+
TARGET_ARCH: amd64
45+
TARGET_VARIANT: 'pointer-compression'
46+
agents:
47+
image: family/kibana-ubuntu-2004
48+
provider: gcp
49+
machineType: c2-standard-16
50+
timeout_in_minutes: 60 # ideally runs in ~30m
5251

53-
# See https://github.com/nodejs/node/issues/54531
54-
# - label: Build custom node.js artifacts with pointer compression for arm64
55-
# command:
56-
# - scripts/create_build_images.sh
57-
# - scripts/build_nodejs.sh
58-
# - scripts/upload_nodejs_artifacts.sh
59-
# env:
60-
# TARGET_ARCH: arm64
61-
# TARGET_VARIANT: 'pointer-compression'
62-
# agents:
63-
# image: family/kibana-ubuntu-2004
64-
# provider: gcp
65-
# machineType: c2-standard-60
66-
# timeout_in_minutes: 180 # ideally runs in ~2hr
52+
- label: Build custom node.js artifacts with pointer compression for arm64
53+
command:
54+
- scripts/create_build_images.sh
55+
- scripts/build_nodejs.sh
56+
- scripts/upload_nodejs_artifacts.sh
57+
env:
58+
TARGET_ARCH: arm64
59+
TARGET_VARIANT: 'pointer-compression'
60+
agents:
61+
image: family/kibana-ubuntu-2004
62+
provider: gcp
63+
machineType: c2-standard-60
64+
timeout_in_minutes: 180 # ideally runs in ~2hr
6765

6866
- wait
6967

@@ -77,13 +75,12 @@ steps:
7775
provider: gcp
7876
machineType: n2-standard-2
7977

80-
# See https://github.com/nodejs/node/issues/54531
81-
# - label: Fix SHASUMS256.txt with newly built files' hashes with pointer compression
82-
# command:
83-
# - scripts/replace_sha_hashes.sh
84-
# env:
85-
# TARGET_VARIANT: 'pointer-compression'
86-
# agents:
87-
# image: family/kibana-ubuntu-2004
88-
# provider: gcp
89-
# machineType: n2-standard-2
78+
- label: Fix SHASUMS256.txt with newly built files' hashes with pointer compression
79+
command:
80+
- scripts/replace_sha_hashes.sh
81+
env:
82+
TARGET_VARIANT: 'pointer-compression'
83+
agents:
84+
image: family/kibana-ubuntu-2004
85+
provider: gcp
86+
machineType: n2-standard-2

0 commit comments

Comments
 (0)