Skip to content

Commit 96ef75b

Browse files
committed
Printing process warning's via the appropriate logger
1 parent d0992b8 commit 96ef75b

File tree

10 files changed

+21
-4
lines changed

10 files changed

+21
-4
lines changed

bin/kibana

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,4 @@ if [ ! -x "$NODE" ]; then
2121
exit 1
2222
fi
2323

24-
exec "${NODE}" $NODE_OPTIONS "${DIR}/src/cli" ${@}
24+
exec "${NODE}" $NODE_OPTIONS --no-warnings "${DIR}/src/cli" ${@}

bin/kibana-plugin

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,4 @@ if [ ! -x "$NODE" ]; then
2121
exit 1
2222
fi
2323

24-
exec "${NODE}" $NODE_OPTIONS "${DIR}/src/cli_plugin" ${@}
24+
exec "${NODE}" $NODE_OPTIONS --no-warnings "${DIR}/src/cli_plugin" ${@}

bin/kibana-plugin.bat

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ If Not Exist "%NODE%" (
2222
)
2323

2424
TITLE Kibana Server
25-
"%NODE%" %NODE_OPTIONS% "%DIR%\src\cli_plugin" %*
25+
"%NODE%" %NODE_OPTIONS% --no-warnings "%DIR%\src\cli_plugin" %*
2626

2727
:finally
2828

bin/kibana.bat

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ If Not Exist "%NODE%" (
2222
)
2323

2424
TITLE Kibana Server
25-
"%NODE%" %NODE_OPTIONS% "%DIR%\src\cli" %*
25+
"%NODE%" %NODE_OPTIONS% --no-warnings "%DIR%\src\cli" %*
2626

2727
:finally
2828

src/cli_plugin/install/index.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import pkg from '../../utils/package_json';
66
import { getConfig } from '../../server/path';
77
import { parse, parseMilliseconds } from './settings';
88
import { find } from 'lodash';
9+
import logWarnings from '../lib/log_warnings';
910

1011
function processCommand(command, options) {
1112
let settings;
@@ -18,6 +19,7 @@ function processCommand(command, options) {
1819
}
1920

2021
const logger = new Logger(settings);
22+
logWarnings(settings, logger);
2123
install(settings, logger);
2224
}
2325

src/cli_plugin/lib/log_warnings.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
export default function (settings, logger) {
2+
process.on('warning', (warning) => {
3+
logger.error(warning);
4+
});
5+
}

src/cli_plugin/list/index.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import { fromRoot } from '../../utils';
22
import list from './list';
33
import Logger from '../lib/logger';
44
import { parse } from './settings';
5+
import logWarnings from '../lib/log_warnings';
56

67
function processCommand(command, options) {
78
let settings;
@@ -14,6 +15,7 @@ function processCommand(command, options) {
1415
}
1516

1617
const logger = new Logger(settings);
18+
logWarnings(settings, logger);
1719
list(settings, logger);
1820
}
1921

src/cli_plugin/remove/index.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import remove from './remove';
33
import Logger from '../lib/logger';
44
import { parse } from './settings';
55
import { getConfig } from '../../server/path';
6+
import logWarnings from '../lib/log_warnings';
67

78
function processCommand(command, options) {
89
let settings;
@@ -15,6 +16,7 @@ function processCommand(command, options) {
1516
}
1617

1718
const logger = new Logger(settings);
19+
logWarnings(settings, logger);
1820
remove(settings, logger);
1921
}
2022

src/server/kbn_server.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ module.exports = class KbnServer {
1919
require('./config/setup'), // sets this.config, reads this.settings
2020
require('./http'), // sets this.server
2121
require('./logging'),
22+
require('./warnings'),
2223
require('./status'),
2324

2425
// writes pid file

src/server/warnings/index.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
export default function (kbnServer, server, config) {
2+
process.on('warning', (warning) => {
3+
server.log(['warning', 'process'], warning);
4+
});
5+
}

0 commit comments

Comments
 (0)