Skip to content

Commit 1533909

Browse files
committed
fix(electron-updater): electron-updater must not depend on builder-util
1 parent 39ac82f commit 1533909

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

packages/electron-updater/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "electron-updater",
3-
"version": "4.3.9",
3+
"version": "4.3.10",
44
"description": "Cross platform updater for electron applications",
55
"main": "out/main.js",
66
"author": "Vladimir Krivosheev",
@@ -13,7 +13,6 @@
1313
],
1414
"dependencies": {
1515
"@types/semver": "^7.3.6",
16-
"builder-util": "workspace:*",
1716
"builder-util-runtime": "workspace:*",
1817
"fs-extra": "^10.0.0",
1918
"js-yaml": "^4.1.0",

packages/electron-updater/src/MacUpdater.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import { AppUpdater, DownloadUpdateOptions } from "./AppUpdater"
88
import { ResolvedUpdateFileInfo } from "./main"
99
import { findFile } from "./providers/Provider"
1010
import AutoUpdater = Electron.AutoUpdater
11-
import { spawn } from "builder-util"
11+
import { execFileSync } from "child_process"
1212

1313
export class MacUpdater extends AppUpdater {
1414
private readonly nativeUpdater: AutoUpdater = require("electron").autoUpdater
@@ -34,8 +34,8 @@ export class MacUpdater extends AppUpdater {
3434
const sysctlRosettaInfoKey = "sysctl.proc_translated"
3535
let isRosetta: boolean
3636
try {
37-
const results = await spawn(`sysctl`, [sysctlRosettaInfoKey])
38-
isRosetta = results?.toString()?.includes(`${sysctlRosettaInfoKey}: 1`)
37+
const result = execFileSync("sysctl", [sysctlRosettaInfoKey], { encoding: "utf8" })
38+
isRosetta = result.includes(`${sysctlRosettaInfoKey}: 1`)
3939
} catch (e) {
4040
this._logger.info(`sysctl shell command to check for macOS Rosetta environment failed: ${e}`)
4141
}

0 commit comments

Comments
 (0)