chore: lint, prettier, and PR Github Action (#5910)

* chore: fixing linter error and running prettier
* Adding PRs against master branch to Github Actions

Author: mmaietta

.github/workflows/test.yaml

@@ -1,6 +1,11 @@
 name: Test
+
 on:
   push:
+  pull_request:
+    branches:
+      - master
+
 jobs:
   test:
     runs-on: ubuntu-20.04

packages/app-builder-lib/src/targets/nsis/NsisTarget.ts

@@ -119,14 +119,14 @@ export class NsisTarget extends Target {
 
   async finishBuild(): Promise<any> {
     try {
-      const { pattern } = this.packager.artifactPatternConfig(this.options, this.installerFilenamePattern);
-      const builds = new Set([this.archs]);
+      const { pattern } = this.packager.artifactPatternConfig(this.options, this.installerFilenamePattern)
+      const builds = new Set([this.archs])
       if (pattern.includes("${arch}") && this.archs.size > 1) {
-          ;[...this.archs].forEach(([arch, appOutDir]) => builds.add(new Map().set(arch, appOutDir)));
+        ;[...this.archs].forEach(([arch, appOutDir]) => builds.add(new Map().set(arch, appOutDir)))
       }
-      const doBuildArchs = builds.values();
-      for (let archs of doBuildArchs) {
-          await this.buildInstaller(archs);
+      const doBuildArchs = builds.values()
+      for (const archs of doBuildArchs) {
+        await this.buildInstaller(archs)
       }
     } finally {
       await this.packageHelper.finishBuild()

test/src/updater/differentialUpdateTest.ts

@@ -335,11 +335,14 @@ async function testBlockMap(oldDir: string, newDir: string, updaterClass: any, a
     doTest()
       .then(() => resolve(null))
       .catch(reject)
-  }).then(v => {
-    httpServerProcess.kill()
-    return v
-  }, e => {
-    httpServerProcess.kill()
-    throw e
-  })
+  }).then(
+    v => {
+      httpServerProcess.kill()
+      return v
+    },
+    e => {
+      httpServerProcess.kill()
+      throw e
+    }
+  )
 }

test/src/windows/appxTest.ts

@@ -20,8 +20,7 @@ it.ifDevOrWinCi(
       projectDirCreated: async projectDir => {
         const targetDir = path.join(projectDir, "build", "appx")
         await mkdir(targetDir, { recursive: true })
-        await Promise.all(["BadgeLogo.scale-100.png", "BadgeLogo.scale-140.png", "BadgeLogo.scale-180.png"]
-          .map(it => copyTestAsset(`appx-assets/${it}`, path.join(targetDir, it))))
+        await Promise.all(["BadgeLogo.scale-100.png", "BadgeLogo.scale-140.png", "BadgeLogo.scale-180.png"].map(it => copyTestAsset(`appx-assets/${it}`, path.join(targetDir, it))))
       },
       signedWin: true,
     }