Skip to content

Commit 668bbb4

Browse files
committed
reverting #9068
1 parent 8e1c7ff commit 668bbb4

File tree

4 files changed

+13
-7
lines changed

4 files changed

+13
-7
lines changed

.changeset/sour-cars-listen.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"app-builder-lib": patch
3+
---
4+
5+
fix: revert PR https://github.com/electron-userland/electron-builder/pull/9068 due to breaking change

packages/app-builder-lib/scheme.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1965,7 +1965,7 @@
19651965
"description": "The executable parameters. Pass to executableName"
19661966
},
19671967
"executableName": {
1968-
"description": "The executable name. Defaults to `productName`.",
1968+
"description": "The executable name. Defaults to `productName`\nNote: Except for Linux, where this would constitute a breaking change in previous behavior and lead to both invalid executable names and Desktop files. Ref comments in: https://github.com/electron-userland/electron-builder/pull/9068",
19691969
"type": [
19701970
"null",
19711971
"string"
@@ -2659,7 +2659,7 @@
26592659
]
26602660
},
26612661
"executableName": {
2662-
"description": "The executable name. Defaults to `productName`.",
2662+
"description": "The executable name. Defaults to `productName`\nNote: Except for Linux, where this would constitute a breaking change in previous behavior and lead to both invalid executable names and Desktop files. Ref comments in: https://github.com/electron-userland/electron-builder/pull/9068",
26632663
"type": [
26642664
"null",
26652665
"string"
@@ -3294,7 +3294,7 @@
32943294
]
32953295
},
32963296
"executableName": {
3297-
"description": "The executable name. Defaults to `productName`.",
3297+
"description": "The executable name. Defaults to `productName`\nNote: Except for Linux, where this would constitute a breaking change in previous behavior and lead to both invalid executable names and Desktop files. Ref comments in: https://github.com/electron-userland/electron-builder/pull/9068",
32983298
"type": [
32993299
"null",
33003300
"string"
@@ -6605,7 +6605,7 @@
66056605
]
66066606
},
66076607
"executableName": {
6608-
"description": "The executable name. Defaults to `productName`.",
6608+
"description": "The executable name. Defaults to `productName`\nNote: Except for Linux, where this would constitute a breaking change in previous behavior and lead to both invalid executable names and Desktop files. Ref comments in: https://github.com/electron-userland/electron-builder/pull/9068",
66096609
"type": [
66106610
"null",
66116611
"string"
@@ -7380,7 +7380,7 @@
73807380
]
73817381
},
73827382
"executableName": {
7383-
"description": "The executable name. Defaults to `productName`.",
7383+
"description": "The executable name. Defaults to `productName`\nNote: Except for Linux, where this would constitute a breaking change in previous behavior and lead to both invalid executable names and Desktop files. Ref comments in: https://github.com/electron-userland/electron-builder/pull/9068",
73847384
"type": [
73857385
"null",
73867386
"string"

packages/app-builder-lib/src/linuxPackager.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ export class LinuxPackager extends PlatformPackager<LinuxConfiguration> {
1818
super(info, Platform.LINUX)
1919

2020
const executableName = this.platformSpecificBuildOptions.executableName ?? info.config.executableName
21-
this.executableName = executableName == null ? this.appInfo.sanitizedProductName : sanitizeFileName(executableName)
21+
this.executableName = executableName == null ? this.appInfo.sanitizedName.toLowerCase() : sanitizeFileName(executableName)
2222
}
2323

2424
get defaultTarget(): Array<string> {

packages/app-builder-lib/src/options/PlatformSpecificBuildOptions.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,8 @@ export interface PlatformSpecificBuildOptions extends TargetSpecificOptions, Fil
106106
readonly artifactName?: string | null
107107

108108
/**
109-
* The executable name. Defaults to `productName`.
109+
* The executable name. Defaults to `productName`
110+
* Note: Except for Linux, where this would constitute a breaking change in previous behavior and lead to both invalid executable names and Desktop files. Ref comments in: https://github.com/electron-userland/electron-builder/pull/9068
110111
*/
111112
readonly executableName?: string | null
112113

0 commit comments

Comments
 (0)