Filter mobile link

[bmarty]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

Accept only root path on mobile.element.io link, to prevent Element Android to intercept link that are for Element X Android or Element Pro.

Note that the link must contain the path / like this:

• https://mobile.element.io/?hs_url=https%3A%2F%2Felement.io

Without it, i.e.:

• https://mobile.element.io?hs_url=https%3A%2F%2Felement.io

Element Android will not handle the link and it will be opened in the browser.

Motivation and context

Ensure the targeted application open the link and not another one.

Screenshots / GIFs

NA

Tests

• Install the app
• Run the script tools/tests/test_configuration_link.sh
• Ensure that Element Android is started and not another app or the browser
• Click on "SIGN IN"
• Ensure that the default account provider is element.io

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes has been tested on an Android device or Android emulator with API 21
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/element-hq/element-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR
• If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

[ElementBot]

	Warnings
⚠️	vector/src/main/AndroidManifest.xml#L16 - READ_EXTERNAL_STORAGE is deprecated (and is not granted) when targeting Android 13+. If you need to query or interact with MediaStore or media files on the shared storage, you should instead use one or more new storage permissions: READ_MEDIA_IMAGES, READ_MEDIA_VIDEO or READ_MEDIA_AUDIO.
⚠️	vector/src/main/AndroidManifest.xml#L16 - READ_EXTERNAL_STORAGE is deprecated (and is not granted) when targeting Android 13+. If you need to query or interact with MediaStore or media files on the shared storage, you should instead use one or more new storage permissions: READ_MEDIA_IMAGES, READ_MEDIA_VIDEO or READ_MEDIA_AUDIO.
⚠️	vector/src/main/AndroidManifest.xml#L195 - Attribute autoVerify is only used in API level 23 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L195 - Attribute autoVerify is only used in API level 23 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L210 - Attribute autoVerify is only used in API level 23 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L210 - Attribute autoVerify is only used in API level 23 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L240 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion
⚠️	vector/src/main/AndroidManifest.xml#L240 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion
⚠️	vector/src/main/AndroidManifest.xml#L243 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion
⚠️	vector/src/main/AndroidManifest.xml#L243 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion
⚠️	vector/src/main/AndroidManifest.xml#L297 - Expecting android:screenOrientation="unspecified" or "fullSensor" for this activity so the user can use the application in any orientation and provide a great experience on Chrome OS devices
⚠️	vector/src/main/AndroidManifest.xml#L297 - Expecting android:screenOrientation="unspecified" or "fullSensor" for this activity so the user can use the application in any orientation and provide a great experience on Chrome OS devices
⚠️	vector/src/main/AndroidManifest.xml#L297 - Should not restrict activity to fixed orientation. This may not be suitable for different form factors, causing the app to be letterboxed.
⚠️	vector/src/main/AndroidManifest.xml#L297 - Should not restrict activity to fixed orientation. This may not be suitable for different form factors, causing the app to be letterboxed.
⚠️	vector/src/main/AndroidManifest.xml#L306 - Attribute supportsPictureInPicture is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L306 - Attribute supportsPictureInPicture is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L313 - Attribute supportsPictureInPicture is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L313 - Attribute supportsPictureInPicture is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L319 - Attribute supportsPictureInPicture is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L319 - Attribute supportsPictureInPicture is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L448 - Exported receiver does not require permission
⚠️	vector/src/main/AndroidManifest.xml#L448 - Exported receiver does not require permission

Generated by 🚫 dangerJS against 02e93fd

[jmartinesp]

LGTM, thanks!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud