test: Try semver-compare

Author: jcs090218

package-lock.json

@@ -37,7 +37,8 @@
   },
   "devDependencies": {
     "@yao-pkg/pkg": "^6.0.0",
-    "jest": "^29.7.0"
+    "jest": "^29.7.0",
+    "semver-compare": "^1.0.0"
   },
   "jest": {
     "rootDir": "./test/jest",

package.json

@@ -1,13 +1,14 @@
+const cmp = require('semver-compare');
 const { emacsVersion, TestContext } = require("./helpers");
 
 describe("exec", () => {
   const ctx = new TestContext("./test/jest/exec");
 
-  // See https://github.com/emacs-eask/cli/issues/11.
-  const avoid11 = (emacsVersion() < "28.1");
-
   beforeAll(async () => {
-    await ctx.runEask("install-deps", { timeout: 40000 }, avoid11)
+    await ctx.runEask(
+      "install-deps", { timeout: 40000 },
+      // See https://github.com/emacs-eask/cli/issues/11.
+      cmp(await emacsVersion(), "28.1") == -1))
   });
 
   afterAll(() => ctx.cleanUp());

test/jest/exec.test.js

@@ -1,22 +1,24 @@
+const cmp = require('semver-compare');
 const { emacsVersion, TestContext } = require("./helpers");
 
 describe("install and uninstall", () => {
   describe("in ./install", () => {
     const ctx = new TestContext("./test/jest/install/");
     const packageName = "mini.pkg.1";
 
-    // See https://github.com/emacs-eask/cli/issues/11.
-    const avoid11 = (emacsVersion() < "28.1");
-
     beforeAll(async () => {
       await ctx.runEask("clean all");
     });
 
     afterAll(() => ctx.cleanUp());
 
     it("installs project package", async () => {
-      await ctx.runEask("package", avoid11);  // creates dist/<pkg>.tar
-      await ctx.runEask("install");  // installs dependencies and generated package
+      // creates dist/<pkg>.tar
+      await ctx.runEask("package",
+                        // See https://github.com/emacs-eask/cli/issues/11.
+                        cmp(await emacsVersion(), "28.1") == -1);
+      // installs dependencies and generated package
+      await ctx.runEask("install");
       const { stderr } = await ctx.runEask("list");
       expect(stderr).toMatch(packageName);
     });
@@ -39,13 +41,18 @@ describe("install and uninstall", () => {
     });
 
     it("uninstalls project package", async () => {
-      await ctx.runEask("uninstall", avoid11);
+      await ctx.runEask("uninstall",
+                        // See https://github.com/emacs-eask/cli/issues/11.
+                        cmp(await emacsVersion(), "28.1") == -1);
       const { stderr } = await ctx.runEask("list");
       expect(stderr).not.toMatch(packageName);
     });
 
     it("installs dependencies", async () => {
-      const { stderr } = await ctx.runEask("install-deps", { timeout: 40000 }, avoid11);
+      const { stderr } = await ctx.runEask(
+        "install-deps", { timeout: 40000 },
+        // See https://github.com/emacs-eask/cli/issues/11.
+        cmp(await emacsVersion(), "28.1") == -1);
       expect(stderr).not.toMatch(packageName);
     });
 

test/jest/install.test.js

@@ -4,20 +4,21 @@
 // Notice, below we clone a random package (repo) that uses Eask as the
 // dependencies management tool.
 
+const cmp = require('semver-compare');
 const { emacsVersion, TestContext } = require("./helpers");
 
 describe("local", () => {
   const cwd = "./test/jest/local";
   const ctx = new TestContext(cwd);
 
-  // See https://github.com/emacs-eask/cli/issues/11.
-  const avoid11 = (emacsVersion() < "28.1");
-
   // NOTE: `install-deps` takes a long time in this package
   //       this is because of recipe dependencies triggering
   //       "temporary archives" build.
   beforeAll(async () => {
-    await ctx.runEask("install-deps", { timeout: 40000 }, avoid11)
+    await ctx.runEask(
+      "install-deps", { timeout: 40000 },
+      // See https://github.com/emacs-eask/cli/issues/11.
+      cmp(await emacsVersion(), "28.1") == -1);
   });
 
   afterAll(() => ctx.cleanUp());
@@ -83,7 +84,10 @@ describe("local", () => {
 
   describe("Development", () => {
     beforeAll(async () => {
-      await ctx.runEask("install-deps", { timeout: 40000 }, avoid11)
+      await ctx.runEask(
+        "install-deps", { timeout: 40000 },
+        // See https://github.com/emacs-eask/cli/issues/11.
+        ((await emacsVersion()) < "28.1"))
     });
 
     // this requires install-deps

test/jest/local.test.js

@@ -1,13 +1,14 @@
+const cmp = require('semver-compare');
 const { emacsVersion, TestContext } = require("./helpers");
 
 describe("outdated and upgrade", () => {
   const ctx = new TestContext("./test/jest/outdated-upgrade");
 
-  // See https://github.com/emacs-eask/cli/issues/11.
-  const avoid11 = (emacsVersion() < "28.1");
-
   beforeAll(async () => {
-    await ctx.runEask("install-deps", { timeout: 40000 }, avoid11);
+    await ctx.runEask(
+      "install-deps", { timeout: 40000 },
+      // See https://github.com/emacs-eask/cli/issues/11.
+      cmp(await emacsVersion(), "28.1") == -1);
     await ctx.runEask("load make-outdate.el");
   });