Skip to content

Commit 4192b92

Browse files
committed
Revert "[BUGFIX lts] Ensures that computed can depend on dynamic hash keys"
This reverts commit 646769e.
1 parent 886bc51 commit 4192b92

File tree

3 files changed

+139
-193
lines changed

3 files changed

+139
-193
lines changed

package.json

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
"@babel/plugin-transform-block-scoping": "^7.8.3",
5252
"@babel/plugin-transform-object-assign": "^7.8.3",
5353
"@ember/edition-utils": "^1.2.0",
54-
"@glimmer/vm-babel-plugins": "0.79.3",
54+
"@glimmer/vm-babel-plugins": "0.79.2",
5555
"babel-plugin-debug-macros": "^0.3.3",
5656
"babel-plugin-filter-imports": "^4.0.0",
5757
"broccoli-concat": "^4.2.4",
@@ -76,19 +76,19 @@
7676
},
7777
"devDependencies": {
7878
"@babel/preset-env": "^7.9.5",
79-
"@glimmer/compiler": "0.79.3",
80-
"@glimmer/destroyable": "0.79.3",
79+
"@glimmer/compiler": "0.79.2",
80+
"@glimmer/destroyable": "0.79.2",
8181
"@glimmer/env": "^0.1.7",
82-
"@glimmer/global-context": "0.79.3",
83-
"@glimmer/interfaces": "0.79.3",
84-
"@glimmer/manager": "0.79.3",
85-
"@glimmer/node": "0.79.3",
86-
"@glimmer/opcode-compiler": "0.79.3",
87-
"@glimmer/owner": "0.79.3",
88-
"@glimmer/program": "0.79.3",
89-
"@glimmer/reference": "0.79.3",
90-
"@glimmer/runtime": "0.79.3",
91-
"@glimmer/validator": "0.79.3",
82+
"@glimmer/global-context": "0.79.2",
83+
"@glimmer/interfaces": "0.79.2",
84+
"@glimmer/manager": "0.79.2",
85+
"@glimmer/node": "0.79.2",
86+
"@glimmer/opcode-compiler": "0.79.2",
87+
"@glimmer/owner": "0.79.2",
88+
"@glimmer/program": "0.79.2",
89+
"@glimmer/reference": "0.79.2",
90+
"@glimmer/runtime": "0.79.2",
91+
"@glimmer/validator": "0.79.2",
9292
"@simple-dom/document": "^1.4.0",
9393
"@types/qunit": "^2.9.1",
9494
"@types/rsvp": "^4.0.3",

packages/@ember/-internals/glimmer/tests/integration/helpers/hash-test.js

Lines changed: 0 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -219,60 +219,6 @@ moduleFor(
219219
this.assertText('Godfrey Chan');
220220
}
221221

222-
['@test works with computeds on non-defined properties']() {
223-
let instance;
224-
225-
let FooBarComponent = Component.extend({
226-
init() {
227-
this._super(...arguments);
228-
229-
if (HAS_NATIVE_PROXY) {
230-
expectDeprecation(() => {
231-
set(this.hash, 'lastName', 'Hietala');
232-
}, /You set the '.*' property on a {{hash}} object/);
233-
} else {
234-
set(this.hash, 'lastName', 'Hietala');
235-
}
236-
237-
instance = this;
238-
},
239-
240-
fullName: computed('hash.firstName', 'hash.lastName', function () {
241-
return `${this.hash.firstName} ${this.hash.lastName}`;
242-
}),
243-
});
244-
245-
this.registerComponent('foo-bar', {
246-
ComponentClass: FooBarComponent,
247-
template: `{{this.fullName}}`,
248-
});
249-
250-
this.render(`{{foo-bar hash=(hash firstName=this.firstName)}}`, {
251-
firstName: 'Chad',
252-
lastName: 'Hietala',
253-
});
254-
255-
this.assertText('Chad Hietala');
256-
257-
runTask(() => this.rerender());
258-
259-
this.assertText('Chad Hietala');
260-
261-
runTask(() => {
262-
set(this.context, 'firstName', 'Godfrey');
263-
264-
if (HAS_NATIVE_PROXY) {
265-
expectDeprecation(() => {
266-
set(instance.hash, 'lastName', 'Chan');
267-
}, /You set the '.*' property on a {{hash}} object/);
268-
} else {
269-
set(instance.hash, 'lastName', 'Chan');
270-
}
271-
});
272-
273-
this.assertText('Godfrey Chan');
274-
}
275-
276222
['@test works when properties are set dynamically']() {
277223
let fooBarInstance;
278224
let FooBarComponent = Component.extend({

0 commit comments

Comments
 (0)