Commit 4f0108f
Revert "improve fn & on undefined callback message"
This reverts commit f6f9f52.
The changes landed cause failures in CI (I should have rebased the
branch to make sure that the code still worked after the last few
glimmer-vm updates).
```
[0413/140947.176661:INFO:CONSOLE(52)] " Failed assertion: Promise rejected during " model is tracked": args.positional.at(...).debug is not a function
TypeError: args.positional.at(...).debug is not a function
at OnModifierState.updateFromArgs (http://localhost:13141/tests/ember.js:9767:68)
at OnModifierManager.install (http://localhost:13141/tests/ember.js:10002:13)
at TransactionImpl.commit (http://localhost:13141/tests/ember.js:48873:19)
at EnvironmentImpl.commit (http://localhost:13141/tests/ember.js:49009:19)
at inTransaction (http://localhost:13141/tests/ember.js:49167:13)
at InteractiveRenderer._renderRoots (http://localhost:13141/tests/ember.js:11540:37)
at InteractiveRenderer._renderRootsTransaction (http://localhost:13141/tests/ember.js:11601:14)
at InteractiveRenderer._renderRoot (http://localhost:13141/tests/ember.js:11527:12)
at InteractiveRenderer._appendDefinition (http://localhost:13141/tests/ember.js:11442:12)
at InteractiveRenderer.appendOutletView (http://localhost:13141/tests/ember.js:11428:12)", source: (52)
```
(cherry picked from commit 109566a)1 parent f18a276 commit 4f0108f
File tree
3 files changed
+6
-11
lines changed- packages/@ember/-internals/glimmer
- lib
- helpers
- modifiers
- tests/integration/helpers
3 files changed
+6
-11
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
88 | | - | |
89 | 88 | | |
90 | | - | |
| 89 | + | |
91 | 90 | | |
92 | 91 | | |
93 | 92 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
100 | 100 | | |
101 | 101 | | |
102 | 102 | | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | 103 | | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
112 | 108 | | |
113 | 109 | | |
114 | 110 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
127 | 127 | | |
128 | 128 | | |
129 | 129 | | |
130 | | - | |
| 130 | + | |
131 | 131 | | |
132 | 132 | | |
133 | 133 | | |
| |||
0 commit comments