Skip to content

Commit ff412b4

Browse files
hateeyanemiago
authored andcommitted
fix: nil UriParams when uri with port
Signed-off-by: hateeyan <[email protected]>
1 parent 6928e66 commit ff412b4

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

sip/parse_address_test.go

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,20 @@ func TestParseAddressValue(t *testing.T) {
4848
assert.Equal(t, false, uri.IsEncrypted())
4949
})
5050

51+
t.Run("nil uri params", func(t *testing.T) {
52+
address := "sip:[email protected]:5066"
53+
uri := Uri{}
54+
params := NewParams()
55+
displayName, err := ParseAddressValue(address, &uri, params)
56+
require.NoError(t, err)
57+
58+
assert.Equal(t, "", displayName)
59+
assert.Equal(t, "1215174826", uri.User)
60+
assert.Equal(t, "222.222.222.222", uri.Host)
61+
assert.Equal(t, HeaderParams{}, uri.UriParams)
62+
assert.Equal(t, false, uri.IsEncrypted())
63+
})
64+
5165
t.Run("wildcard", func(t *testing.T) {
5266
address := "*"
5367
uri := Uri{}

sip/parse_uri.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ func uriStatePort(uri *Uri, s string) (uriFSM, string, error) {
120120
}
121121

122122
uri.Port, err = strconv.Atoi(s)
123-
return nil, s, err
123+
return uriStateUriParams, "", err
124124
}
125125

126126
func uriStateUriParams(uri *Uri, s string) (uriFSM, string, error) {

0 commit comments

Comments
 (0)