Skip to content

Commit 2377d60

Browse files
author
bors-servo
authored
Auto merge of servo#19371 - emilio:doc-colors, r=whoops
style: Don't insert into the `seen` set before ignoring document colors. Otherwise we may stop honoring other colors in other cascade levels. Fixes: servo#19370 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19371) <!-- Reviewable:end -->
2 parents 6158a4b + 4c02ad0 commit 2377d60

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

components/style/properties/properties.mako.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3330,7 +3330,6 @@ where
33303330
if seen.contains(physical_longhand_id) {
33313331
continue
33323332
}
3333-
seen.insert(physical_longhand_id);
33343333

33353334
let mut declaration = match *declaration {
33363335
PropertyDeclaration::WithVariables(id, ref unparsed) => {
@@ -3376,6 +3375,8 @@ where
33763375
}
33773376
}
33783377

3378+
seen.insert(physical_longhand_id);
3379+
33793380
% if category_to_cascade_now == "early":
33803381
if LonghandId::FontSize == longhand_id {
33813382
font_size = Some(declaration.clone());

0 commit comments

Comments
 (0)