Skip to content

Commit 1bde14c

Browse files
authored
Fix wasm worker tests in high memory modes (#21319)
1 parent 57ba793 commit 1bde14c

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

.circleci/config.yml

+2
Original file line numberDiff line numberDiff line change
@@ -822,6 +822,7 @@ jobs:
822822
browser_2gb.test_webgl2_*
823823
browser_2gb.test_webgl_*
824824
browser_2gb.test_sdl_image
825+
browser_2gb.test_wasm_worker*
825826
"
826827
test-browser-chrome-wasm64-4gb:
827828
executor: bionic
@@ -839,6 +840,7 @@ jobs:
839840
browser64_4gb.test_fulles2_sdlproc
840841
browser64_4gb.test_html5_webgl_create_context*
841842
browser64_4gb.test_sdl_image
843+
browser64_4gb.test_wasm_worker*
842844
"
843845
test-browser-firefox:
844846
executor: bionic

src/library_wasm_worker.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -278,9 +278,9 @@ if (ENVIRONMENT_IS_WASM_WORKER) {
278278
};
279279
let tryAcquireLock = () => {
280280
do {
281-
var val = Atomics.compareExchange(HEAP32, lock >> 2, 0/*zero represents lock being free*/, 1/*one represents lock being acquired*/);
281+
var val = Atomics.compareExchange(HEAP32, {{{ getHeapOffset('lock', 'i32') }}}, 0/*zero represents lock being free*/, 1/*one represents lock being acquired*/);
282282
if (!val) return dispatch(0, 0/*'ok'*/);
283-
var wait = Atomics.waitAsync(HEAP32, lock >> 2, val, maxWaitMilliseconds);
283+
var wait = Atomics.waitAsync(HEAP32, {{{ getHeapOffset('lock', 'i32') }}}, val, maxWaitMilliseconds);
284284
} while (wait.value === 'not-equal');
285285
#if ASSERTIONS
286286
assert(wait.async || wait.value === 'timed-out');
@@ -301,12 +301,12 @@ if (ENVIRONMENT_IS_WASM_WORKER) {
301301
let tryAcquireSemaphore = () => {
302302
let val = num;
303303
do {
304-
let ret = Atomics.compareExchange(HEAP32, sem >> 2,
304+
let ret = Atomics.compareExchange(HEAP32, {{{ getHeapOffset('sem', 'i32') }}},
305305
val, /* We expect this many semaphore resoures to be available*/
306306
val - num /* Acquire 'num' of them */);
307307
if (ret == val) return dispatch(ret/*index of resource acquired*/, 0/*'ok'*/);
308308
val = ret;
309-
let wait = Atomics.waitAsync(HEAP32, sem >> 2, ret, maxWaitMilliseconds);
309+
let wait = Atomics.waitAsync(HEAP32, {{{ getHeapOffset('sem', 'i32') }}}, ret, maxWaitMilliseconds);
310310
} while (wait.value === 'not-equal');
311311
#if ASSERTIONS
312312
assert(wait.async || wait.value === 'timed-out');

test/test_browser.py

+2
Original file line numberDiff line numberDiff line change
@@ -236,6 +236,8 @@ def setUp(self):
236236
def require_wasm2js(self):
237237
if self.is_wasm64():
238238
self.skipTest('wasm2js is not compatible with MEMORY64')
239+
if self.is_2gb() or self.is_4gb():
240+
self.skipTest('wasm2js does not support over 2gb of memory')
239241

240242
def require_jspi(self):
241243
if not is_chrome():

0 commit comments

Comments
 (0)