[esm-integration] Add a new core test mode and either fix or disable all test.

This is fairly larger change which can likely to split up before landing.

Author: sbc100

.circleci/config.yml

@@ -659,6 +659,21 @@ jobs:
     steps:
       - run-tests-linux:
           test_targets: "instance"
+  test-esm-integration:
+    # We don't use `bionic` here since its tool old to run recent node versions:
+    # `/lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found`
+    executor: linux-python
+    steps:
+      - prepare-for-tests
+      # The linux-python image uses /home/circleci rather than /root and jsvu
+      # hardcodes /root into its launcher scripts so we need to reinstall v8.
+      - run: rm -rf $HOME/.jsvu
+      - install-v8
+      - install-node-canary
+      - run-tests:
+          title: "esm-integration"
+          test_targets: "esm-integration"
+      - upload-test-results
   test-wasm2js1:
     environment:
       EMTEST_SKIP_NODE_CANARY: "1"
@@ -811,10 +826,6 @@ jobs:
             core0.test_pthread_join_and_asyncify
             core0.test_async_ccall_promise_jspi*
             core0.test_cubescript_jspi
-            esm_integration.test_fs_js_api*
-            esm_integration.test_inlinejs3
-            esm_integration.test_embind_val_basics
-            esm_integration.test_undefined_main
             "
       # Run some basic tests with the minimum version of node that we currently
       # support in the generated code.
@@ -1142,6 +1153,7 @@ workflows:
       - test-modularize-instance:
           requires:
             - build-linux
+      - test-esm-integration
       - test-browser-chrome
       - test-browser-chrome-2gb:
           requires:

site/source/docs/compiling/Modularized-Output.rst

@@ -138,6 +138,7 @@ fix in future releses.  Current limitations include:
 * The output of file_packager is not compatible so :ref:`emcc-preload-file` and
   :ref:`emcc-embed-file` do not work.
 
+
 Source Phase Imports (experimental)
 ===================================
 
@@ -167,5 +168,14 @@ This setting implicitly enables :ref:`export_es6` and sets :ref:`MODULARIZE` to
 ``instance``.  Because of this all the same limitations mentioned above for
 ``-sMODULARIZE=intance`` apply.
 
+Some additionl limitaion are:
+
+- ``-pthread`` / :ref:`wasm_workers` are not yet supported.
+
+- Setting :ref:`wasm` to ``0`` is not supported.
+
+- Setting :ref:`wasm_async_compilation` to ``0`` is not supported.
+
+
 .. _Source phase imports: https://github.com/tc39/proposal-source-phase-imports
 .. _Wasm ESM integration: https://github.com/WebAssembly/esm-integration

src/lib/libasync.js

@@ -498,6 +498,7 @@ addToLibrary({
     });
   },
 
+#if !SOURCE_PHASE_IMPORTS && !WASM_ESM_INTEGRATION
   emscripten_lazy_load_code__async: true,
   emscripten_lazy_load_code: () => Asyncify.handleSleep((wakeUp) => {
     // Update the expected wasm binary file to be the lazy one.
@@ -517,6 +518,7 @@ addToLibrary({
     var deferred = wasmBinaryFile.slice(0, -5) + '.deferred.wasm';
     await instantiateAsync(null, deferred, imports);
   },
+#endif
 
   $Fibers__deps: ['$Asyncify', 'emscripten_stack_set_limits', '$stackRestore'],
   $Fibers: {

test/common.py

@@ -522,7 +522,7 @@ def metafunc(self, with_minimal_runtime, *args, **kwargs):
       print('parameterize:minimal_runtime=%s' % with_minimal_runtime)
     assert self.get_setting('MINIMAL_RUNTIME') is None
     if with_minimal_runtime:
-      if self.get_setting('MODULARIZE') == 'instance':
+      if self.get_setting('MODULARIZE') == 'instance' or self.get_setting('WASM_ESM_INTEGRATION'):
         self.skipTest('MODULARIZE=instance is not compatible with MINIMAL_RUNTIME')
       self.set_setting('MINIMAL_RUNTIME', 1)
       # This extra helper code is needed to cleanly handle calls to exit() which throw
@@ -604,6 +604,7 @@ def can_do_standalone(self, impure=False):
   return self.is_wasm() and \
       self.get_setting('STACK_OVERFLOW_CHECK', 0) < 2 and \
       not self.get_setting('MINIMAL_RUNTIME') and \
+      not self.get_setting('WASM_ESM_INTEGRATION') and \
       not self.get_setting('SAFE_HEAP') and \
       not any(a.startswith('-fsanitize=') for a in self.emcc_args)
 
@@ -1138,6 +1139,8 @@ def require_wasm2js(self):
       self.skipTest('wasm2js is not compatible with MEMORY64')
     if self.is_2gb() or self.is_4gb():
       self.skipTest('wasm2js does not support over 2gb of memory')
+    if self.get_setting('WASM_ESM_INTEGRATION'):
+      self.skipTest('wasm2js is not compatible with WASM_ESM_INTEGRATION')
 
   def setup_nodefs_test(self):
     self.require_node()
@@ -1160,6 +1163,8 @@ def setup_node_pthreads(self):
     self.emcc_args += ['-Wno-pthreads-mem-growth', '-pthread']
     if self.get_setting('MINIMAL_RUNTIME'):
       self.skipTest('node pthreads not yet supported with MINIMAL_RUNTIME')
+    if self.get_setting('WASM_ESM_INTEGRATION'):
+      self.skipTest('pthreads not yet supported with WASM_ESM_INTEGRATION')
     nodejs = self.get_nodejs()
     self.js_engines = [nodejs]
     self.node_args += shared.node_pthread_flags(nodejs)

test/core/test_demangle_stacks.cpp

@@ -8,6 +8,8 @@
 
 #include <emscripten.h>
 
+EM_JS_DEPS(deps, "$jsStackTrace");
+
 namespace NameSpace {
 class Class {
  public: