Skip to content

test_fibers_asyncify fails without the binaryen generated dynCall functions. #12066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbc100 opened this issue Aug 27, 2020 · 4 comments
Open
Assignees

Comments

@sbc100
Copy link
Collaborator

sbc100 commented Aug 27, 2020

As of #12059 we are moving away form the native dynCall functions but because of wasm2c's dependency we currently use the legacy mode when ASYNCIFY is enabled due to this failure.

The only difference I can thing is that perhaps when entering the wasm module via a native dynCall the dynCall function itself has been asyncified but directly calling a function via the table bypasses that?

See #12002

@kripken
Copy link
Member

kripken commented Aug 29, 2020

I can't get this to fail, what am I doing wrong? I applied the PR #12059 , made sure I have latest binaryen, cleared the cache, and then ran ./tests/runner.py wasm*.test_fibers_asyncify and they all pass.

@kripken
Copy link
Member

kripken commented Aug 29, 2020

Oh, I need to disable the legacy dyncall method in emcc.py, the test doesn't fail on the branch...

@stale
Copy link

stale bot commented Sep 3, 2021

This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 30 days. Feel free to re-open at any time if this issue is still relevant.

@stale stale bot added the wontfix label Sep 3, 2021
@stale stale bot closed this as completed Apr 18, 2022
@sbc100
Copy link
Collaborator Author

sbc100 commented May 21, 2025

This is still an issue.

@sbc100 sbc100 reopened this May 21, 2025
@stale stale bot removed the wontfix label May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants