Skip to content

Commit 7d18916

Browse files
committed
main_panel: Remove “Test” button
This button was connected to a callback which didn't do anything, as an artefact from earlier experimentation. By removing it we can also remove the VBox that contained only the button and the MarginContainer, simplifying the control hierarchy a bit.
1 parent 62e90bf commit 7d18916

File tree

2 files changed

+9
-23
lines changed

2 files changed

+9
-23
lines changed

addons/block_code/ui/main_panel.gd

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,6 @@ func _ready():
3232
block_code_tab = eia.Utils.find_child_by_name(eia.context_switcher, "Block Code")
3333

3434

35-
func _on_button_pressed():
36-
pass
37-
38-
3935
func switch_script(block_code_node: BlockCode):
4036
var bsd = block_code_node.bsd
4137
if bsd:

addons/block_code/ui/main_panel.tscn

Lines changed: 9 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -16,52 +16,42 @@ size_flags_horizontal = 3
1616
size_flags_vertical = 3
1717
script = ExtResource("1_u0xju")
1818

19-
[node name="VBoxContainer" type="VBoxContainer" parent="."]
20-
layout_mode = 2
21-
22-
[node name="Button" type="Button" parent="VBoxContainer"]
23-
layout_mode = 2
24-
size_flags_horizontal = 0
25-
text = "Test"
26-
27-
[node name="MarginContainer" type="MarginContainer" parent="VBoxContainer"]
19+
[node name="MarginContainer" type="MarginContainer" parent="."]
2820
layout_mode = 2
2921
size_flags_vertical = 3
3022

31-
[node name="HBoxContainer" type="HBoxContainer" parent="VBoxContainer/MarginContainer"]
23+
[node name="HBoxContainer" type="HBoxContainer" parent="MarginContainer"]
3224
layout_mode = 2
3325
size_flags_vertical = 3
3426

35-
[node name="ScriptVBox" type="VBoxContainer" parent="VBoxContainer/MarginContainer/HBoxContainer"]
27+
[node name="ScriptVBox" type="VBoxContainer" parent="MarginContainer/HBoxContainer"]
3628
layout_mode = 2
3729
size_flags_horizontal = 3
3830

39-
[node name="TitleBar" parent="VBoxContainer/MarginContainer/HBoxContainer/ScriptVBox" instance=ExtResource("2_k54yf")]
31+
[node name="TitleBar" parent="MarginContainer/HBoxContainer/ScriptVBox" instance=ExtResource("2_k54yf")]
4032
unique_name_in_owner = true
4133
layout_mode = 2
4234

43-
[node name="MarginContainer" type="MarginContainer" parent="VBoxContainer/MarginContainer/HBoxContainer/ScriptVBox"]
35+
[node name="MarginContainer" type="MarginContainer" parent="MarginContainer/HBoxContainer/ScriptVBox"]
4436
layout_mode = 2
4537
size_flags_vertical = 3
4638

47-
[node name="HBoxContainer" type="HBoxContainer" parent="VBoxContainer/MarginContainer/HBoxContainer/ScriptVBox/MarginContainer"]
39+
[node name="HBoxContainer" type="HBoxContainer" parent="MarginContainer/HBoxContainer/ScriptVBox/MarginContainer"]
4840
layout_mode = 2
4941
size_flags_horizontal = 3
5042
size_flags_vertical = 3
5143

52-
[node name="Picker" parent="VBoxContainer/MarginContainer/HBoxContainer/ScriptVBox/MarginContainer/HBoxContainer" instance=ExtResource("2_hv5f3")]
44+
[node name="Picker" parent="MarginContainer/HBoxContainer/ScriptVBox/MarginContainer/HBoxContainer" instance=ExtResource("2_hv5f3")]
5345
unique_name_in_owner = true
5446
layout_mode = 2
5547

56-
[node name="NodeBlockCanvas" parent="VBoxContainer/MarginContainer/HBoxContainer/ScriptVBox/MarginContainer/HBoxContainer" instance=ExtResource("3_ml5y3")]
48+
[node name="NodeBlockCanvas" parent="MarginContainer/HBoxContainer/ScriptVBox/MarginContainer/HBoxContainer" instance=ExtResource("3_ml5y3")]
5749
unique_name_in_owner = true
5850
layout_mode = 2
5951

60-
[node name="DragManager" parent="VBoxContainer/MarginContainer/HBoxContainer/ScriptVBox/MarginContainer" instance=ExtResource("4_yijtu")]
52+
[node name="DragManager" parent="MarginContainer/HBoxContainer/ScriptVBox/MarginContainer" instance=ExtResource("4_yijtu")]
6153
unique_name_in_owner = true
6254
layout_mode = 2
6355
mouse_filter = 2
6456
picker_path = NodePath("../HBoxContainer/Picker")
6557
block_canvas_path = NodePath("../HBoxContainer/NodeBlockCanvas")
66-
67-
[connection signal="pressed" from="VBoxContainer/Button" to="." method="_on_button_pressed"]

0 commit comments

Comments
 (0)