Skip to content

Commit 05f97df

Browse files
[webview_flutter] Make WebKitWebViewWidget unit tests stateless (flutter#6228)
This eliminates the state in the Dart unit tests for this class, bringing it into alignment with https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#make-each-test-entirely-self-contained. - `testController` is now returned by `buildWidget`, which clarifies and enforces that the variable can only be used after `buildWidget` is called - All the mocks are now in a data object that is created via a `configureMocks` call in each test. The latter will allow easily adjusting specific mocks in individual tests (vs having to create a new group that has an almost-identical duplicate of `setUp`, but with slight changes) which will be useful when adding macOS support, where the mock `WKWebView` will need to be a different class when testing macOS/iOS codepath divergence.
1 parent 0625827 commit 05f97df

File tree

1 file changed

+341
-208
lines changed

1 file changed

+341
-208
lines changed

0 commit comments

Comments
 (0)