Skip to content

Commit 1c147a2

Browse files
authored
Deprecate unused ButtonStyleButton.iconAlignment property (flutter#160023)
Fixes [Deprecate unused `ButtonStyleButton.iconAlignment` property](flutter#159782) Refactor done in flutter#158503 makes `ButtonStyleButton.iconAlignment` redundant. In this PR I'm marking it as deprecated without migration guide. However, it may possible to remove it altogether. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
1 parent d14140f commit 1c147a2

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

packages/flutter/lib/src/material/button_style_button.dart

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,11 @@ abstract class ButtonStyleButton extends StatefulWidget {
8686
required this.clipBehavior,
8787
this.statesController,
8888
this.isSemanticButton = true,
89+
@Deprecated(
90+
'Remove this parameter as it is now ignored. '
91+
'Use ButtonStyle.iconAlignment instead. '
92+
'This feature was deprecated after v3.28.0-1.0.pre.',
93+
)
8994
this.iconAlignment,
9095
this.tooltip,
9196
required this.child,
@@ -158,6 +163,11 @@ abstract class ButtonStyleButton extends StatefulWidget {
158163
final bool? isSemanticButton;
159164

160165
/// {@macro flutter.material.ButtonStyleButton.iconAlignment}
166+
@Deprecated(
167+
'Remove this parameter as it is now ignored. '
168+
'Use ButtonStyle.iconAlignment instead. '
169+
'This feature was deprecated after v3.28.0-1.0.pre.',
170+
)
161171
final IconAlignment? iconAlignment;
162172

163173
/// Text that describes the action that will occur when the button is pressed or

0 commit comments

Comments
 (0)