Skip to content

Commit 6745955

Browse files
authored
Remove flaky check from observatory/tracing_test.dart (flutter#51320)
For flutter#144394
1 parent 5bdc0dc commit 6745955

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

testing/dart/observatory/tracing_test.dart

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ Future<void> _testChromeFormatTrace(vms.VmService vmService) async {
1919

2020
int saveLayerRecordCount = 0;
2121
int saveLayerCount = 0;
22-
int flowEventCount = 0;
22+
// int flowEventCount = 0;
2323
for (final vms.TimelineEvent event in timeline.traceEvents!) {
2424
final Map<String, dynamic> json = event.json!;
2525
if (json['ph'] == 'B') {
@@ -29,13 +29,15 @@ Future<void> _testChromeFormatTrace(vms.VmService vmService) async {
2929
if (json['name'] == 'Canvas::saveLayer') {
3030
saveLayerCount += 1;
3131
}
32-
} else if (json['ph'] == 's' || json['ph'] == 't' || json['ph'] == 'f') {
33-
flowEventCount += 1;
3432
}
33+
// else if (json['ph'] == 's' || json['ph'] == 't' || json['ph'] == 'f') {
34+
// flowEventCount += 1;
35+
// }
3536
}
3637
expect(saveLayerRecordCount, 3);
3738
expect(saveLayerCount, impellerEnabled ? 2 : 3);
38-
expect(flowEventCount, 5);
39+
// TODO(derekxu16): Deflake https://github.com/flutter/flutter/issues/144394
40+
// expect(flowEventCount, 5);
3941
}
4042

4143
Future<void> _testPerfettoFormatTrace(vms.VmService vmService) async {
@@ -48,7 +50,7 @@ Future<void> _testPerfettoFormatTrace(vms.VmService vmService) async {
4850

4951
int saveLayerRecordCount = 0;
5052
int saveLayerCount = 0;
51-
int flowIdCount = 0;
53+
// int flowIdCount = 0;
5254
for (final TrackEvent event in events) {
5355
if (event.type == TrackEvent_Type.TYPE_SLICE_BEGIN) {
5456
if (event.name == 'ui.Canvas::saveLayer (Recorded)') {
@@ -57,12 +59,13 @@ Future<void> _testPerfettoFormatTrace(vms.VmService vmService) async {
5759
if (event.name == 'Canvas::saveLayer') {
5860
saveLayerCount += 1;
5961
}
60-
flowIdCount += event.flowIds.length;
62+
// flowIdCount += event.flowIds.length;
6163
}
6264
}
6365
expect(saveLayerRecordCount, 3);
6466
expect(saveLayerCount, impellerEnabled ? 2 : 3);
65-
expect(flowIdCount, 5);
67+
// TODO(derekxu16): Deflake https://github.com/flutter/flutter/issues/144394
68+
// expect(flowIdCount, 5);
6669
}
6770

6871
void main() {

0 commit comments

Comments
 (0)