Skip to content

Commit 68b7b84

Browse files
[fuchsia] Send trace events to system tracing on all configurations (flutter#20974)
This change reverts flutter/engine#15900. The design of the expected consumer of the original PR changed, and the feature ended up going unused. Since the unexpected difference in trace event routing behavior has mostly ended up as a source of confusion, change things back to route trace events to Fuchsia system tracing on all configurations.
1 parent 6e8930b commit 68b7b84

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

runtime/dart_vm.cc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -378,8 +378,7 @@ DartVM::DartVM(std::shared_ptr<const DartVMData> vm_data,
378378
args.push_back(old_gen_heap_size_args.c_str());
379379
}
380380

381-
#if defined(OS_FUCHSIA) && \
382-
(FLUTTER_RUNTIME_MODE != FLUTTER_RUNTIME_MODE_PROFILE)
381+
#if defined(OS_FUCHSIA)
383382
PushBackAll(&args, kDartFuchsiaTraceArgs, fml::size(kDartFuchsiaTraceArgs));
384383
PushBackAll(&args, kDartTraceStreamsArgs, fml::size(kDartTraceStreamsArgs));
385384
#endif

shell/platform/fuchsia/dart_runner/dart_runner.cc

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,7 @@ const char* kDartVMArgs[] = {
3939
// addressed.
4040
"--no_causal_async_stacks",
4141

42-
#if !defined(FLUTTER_PROFILE)
4342
"--systrace_timeline",
44-
#endif
4543
"--timeline_streams=Compiler,Dart,Debugger,Embedder,GC,Isolate,VM",
4644

4745
#if defined(AOT_RUNTIME)

0 commit comments

Comments
 (0)