Skip to content

Commit a85f397

Browse files
ditmanditman
authored
[ci] Run more web tests (flutter#3739)
This change enables the integration_tests of the following packages to run in Cirrus CI: * google_sign_in_web * connectivity_for_web * google_maps_flutter_web * url_launcher_web
1 parent 2068cce commit a85f397

File tree

12 files changed

+470
-405
lines changed

12 files changed

+470
-405
lines changed

‎packages/connectivity/connectivity_for_web/example/run_test.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@ if pgrep -lf chromedriver > /dev/null; then
88

99
if [ $# -eq 0 ]; then
1010
echo "No target specified, running all tests..."
11-
find integration_test/ -iname *_test.dart | xargs -n1 -i -t flutter drive -d web-server --web-port=7357 --browser-name=chrome --driver=test_driver/integration_driver.dart --target='{}'
11+
find integration_test/ -iname *_test.dart | xargs -n1 -i -t flutter drive -d web-server --web-port=7357 --browser-name=chrome --driver=test_driver/integration_test.dart --target='{}'
1212
else
1313
echo "Running test target: $1..."
1414
set -x
15-
flutter drive -d web-server --web-port=7357 --browser-name=chrome --driver=test_driver/integration_driver.dart --target=$1
15+
flutter drive -d web-server --web-port=7357 --browser-name=chrome --driver=test_driver/integration_test.dart --target=$1
1616
fi
1717

1818
else

‎packages/connectivity/connectivity_for_web/example/test_driver/integration_driver.dart renamed to ‎packages/connectivity/connectivity_for_web/example/test_driver/integration_test.dart

File renamed without changes.

‎packages/google_maps_flutter/google_maps_flutter_web/example/run_test.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@ if pgrep -lf chromedriver > /dev/null; then
88

99
if [ $# -eq 0 ]; then
1010
echo "No target specified, running all tests..."
11-
find integration_test/ -iname *_test.dart | xargs -n1 -i -t flutter drive -d web-server --web-port=7357 --browser-name=chrome --driver=test_driver/integration_driver.dart --target='{}'
11+
find integration_test/ -iname *_test.dart | xargs -n1 -i -t flutter drive -d web-server --web-port=7357 --browser-name=chrome --driver=test_driver/integration_test.dart --target='{}'
1212
else
1313
echo "Running test target: $1..."
1414
set -x
15-
flutter drive -d web-server --web-port=7357 --browser-name=chrome --driver=test_driver/integration_driver.dart --target=$1
15+
flutter drive -d web-server --web-port=7357 --browser-name=chrome --driver=test_driver/integration_test.dart --target=$1
1616
fi
1717

1818
else

‎packages/google_maps_flutter/google_maps_flutter_web/example/test_driver/integration_driver.dart renamed to ‎packages/google_maps_flutter/google_maps_flutter_web/example/test_driver/integration_test.dart

File renamed without changes.

‎packages/google_maps_flutter/google_maps_flutter_web/example/web/index.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@
55
<html>
66
<head>
77
<title>Browser Tests</title>
8-
<script src="https://maps.googleapis.com/maps/api/js?key=YOUR_API_KEY&libraries=geometry"></script>
8+
<!-- This API key comes from: go/flutter-maps-web-tests-api-key (GCP project: flutter-infra) -->
9+
<script src="https://maps.googleapis.com/maps/api/js?key=AIzaSyAa9cRBkhuxGq3Xw3HPz8SPwaVOhRmm7kk&libraries=geometry"></script>
910
</head>
1011
<body>
1112
<script src="main.dart.js"></script>

‎packages/google_sign_in/google_sign_in_web/example/run_test.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@ if pgrep -lf chromedriver > /dev/null; then
88

99
if [ $# -eq 0 ]; then
1010
echo "No target specified, running all tests..."
11-
find integration_test/ -iname *_test.dart | xargs -n1 -i -t flutter drive -d web-server --web-port=7357 --browser-name=chrome --driver=test_driver/integration_driver.dart --target='{}'
11+
find integration_test/ -iname *_test.dart | xargs -n1 -i -t flutter drive -d web-server --web-port=7357 --browser-name=chrome --driver=test_driver/integration_test.dart --target='{}'
1212
else
1313
echo "Running test target: $1..."
1414
set -x
15-
flutter drive -d web-server --web-port=7357 --browser-name=chrome --driver=test_driver/integration_driver.dart --target=$1
15+
flutter drive -d web-server --web-port=7357 --browser-name=chrome --driver=test_driver/integration_test.dart --target=$1
1616
fi
1717

1818
else

‎packages/google_sign_in/google_sign_in_web/example/test_driver/integration_driver.dart renamed to ‎packages/google_sign_in/google_sign_in_web/example/test_driver/integration_test.dart

File renamed without changes.

‎packages/url_launcher/url_launcher_web/example/integration_test/url_launcher_web_test.mocks.dart

Lines changed: 458 additions & 396 deletions
Large diffs are not rendered by default.

‎packages/url_launcher/url_launcher_web/example/run_test.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,11 @@ if pgrep -lf chromedriver > /dev/null; then
1313

1414
if [ $# -eq 0 ]; then
1515
echo "No target specified, running all tests..."
16-
find integration_test/ -iname *_test.dart | xargs -n1 -i -t flutter drive -d web-server --web-port=7357 --browser-name=chrome --driver=test_driver/integration_test_driver.dart --target='{}'
16+
find integration_test/ -iname *_test.dart | xargs -n1 -i -t flutter drive -d web-server --web-port=7357 --browser-name=chrome --driver=test_driver/integration_test.dart --target='{}'
1717
else
1818
echo "Running test target: $1..."
1919
set -x
20-
flutter drive -d web-server --web-port=7357 --browser-name=chrome --driver=test_driver/integration_test_driver.dart --target=$1
20+
flutter drive -d web-server --web-port=7357 --browser-name=chrome --driver=test_driver/integration_test.dart --target=$1
2121
fi
2222

2323
else

‎packages/url_launcher/url_launcher_web/example/test_driver/integration_test_driver.dart renamed to ‎packages/url_launcher/url_launcher_web/example/test_driver/integration_test.dart

File renamed without changes.

‎script/tool/lib/src/drive_examples_command.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,7 @@ Tried searching for the following:
146146
driveArgs.addAll(<String>[
147147
'-d',
148148
'web-server',
149+
'--web-port=7357',
149150
'--browser-name=chrome',
150151
]);
151152
}

‎script/tool/test/drive_examples_command_test.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -427,6 +427,7 @@ void main() {
427427
'drive',
428428
'-d',
429429
'web-server',
430+
'--web-port=7357',
430431
'--browser-name=chrome',
431432
'--driver',
432433
driverTestPath,

0 commit comments

Comments
 (0)