Skip to content

Commit c9a2584

Browse files
[ci] Convert version presubmit check to LUCI (flutter#4822)
Adds a LUCI version of the version presubmit check, using the new label passthrough functionality, and removes it from Cirrus. Since that was the last Cirrus task, this removes the entire Cirrus config, and the associated Dockerfile. Part of flutter#130076
1 parent e668c43 commit c9a2584

File tree

4 files changed

+8
-48
lines changed

4 files changed

+8
-48
lines changed

.ci/Dockerfile

Lines changed: 0 additions & 6 deletions
This file was deleted.

.ci/scripts/check_version.sh

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,13 @@
44
# found in the LICENSE file.
55
set -e
66

7-
# For pre-submit, this is currently run in Cirrus; see TODO below.
7+
# For pre-submit, check for missing or breaking changes that don't have a
8+
# corresponding override label.
89
# For post-submit, ignore platform interface breaking version changes and
910
# missing version/CHANGELOG detection since PR-level overrides aren't available
1011
# in post-submit.
1112
if [[ $LUCI_PR == "" ]]; then
1213
./script/tool_runner.sh version-check --ignore-platform-interface-breaks
1314
else
14-
# TODO(stuartmorgan): Migrate this check from Cirrus. See
15-
# https://github.com/flutter/flutter/issues/130076
16-
:
15+
./script/tool_runner.sh version-check --check-for-missing-changes --pr-labels="$PR_OVERRIDE_LABELS"
1716
fi

.ci/targets/repo_checks.yaml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,13 +44,14 @@ tasks:
4444
script: script/tool_runner.sh
4545
args: ["dependabot-check"]
4646
always: true
47-
- name: publishability
48-
script: script/tool_runner.sh
49-
args: ["publish-check", "--allow-pre-release"]
50-
always: true
5147
- name: CHANGELOG and version validation
5248
script: .ci/scripts/check_version.sh
5349
always: true
5450
- name: federated safety check
5551
script: .ci/scripts/check_federated_safety.sh
5652
always: true
53+
# This is the slowest test, so prefer keeping it last.
54+
- name: publishability
55+
script: script/tool_runner.sh
56+
args: ["publish-check", "--allow-pre-release"]
57+
always: true

.cirrus.yml

Lines changed: 0 additions & 34 deletions
This file was deleted.

0 commit comments

Comments
 (0)