Skip to content

Commit 0539c8b

Browse files
authored
Fixes vscode path installed via snap (#136997)
Fixes the #136996 Readresses the #54358 Before: ```sh [✓] VS Code (version unknown) • VS Code at /snap/code/current • Flutter extension version 3.74.0 ✗ Unable to determine VS Code version. ``` After: ```sh [✓] VS Code (version 1.83.1) • VS Code at /snap/code/current/usr/share/code • Flutter extension version 3.74.0 ``` *List which issues are fixed by this PR. You must list at least one issue.* ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
1 parent 2c3c6b0 commit 0539c8b

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

packages/flutter_tools/lib/src/vscode/vscode.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -238,15 +238,15 @@ class VsCode {
238238

239239
// Linux:
240240
// /usr/share/code/bin/code
241-
// /snap/code/current
241+
// /snap/code/current/usr/share/code
242242
// /usr/share/code-insiders/bin/code-insiders
243243
// Linux Extensions:
244244
// $HOME/.vscode/extensions
245245
// $HOME/.vscode-insiders/extensions
246246
static List<VsCode> _installedLinux(FileSystem fileSystem, Platform platform) {
247247
return _findInstalled(<VsCodeInstallLocation>[
248248
const VsCodeInstallLocation('/usr/share/code', '.vscode'),
249-
const VsCodeInstallLocation('/snap/code/current', '.vscode'),
249+
const VsCodeInstallLocation('/snap/code/current/usr/share/code', '.vscode'),
250250
const VsCodeInstallLocation(
251251
'/usr/share/code-insiders',
252252
'.vscode-insiders',

packages/flutter_tools/test/general.shard/vscode/vscode_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ void main() {
4545
const String home = '/home/me';
4646
final Platform platform = FakePlatform(environment: <String, String>{'HOME': home});
4747

48-
fileSystem.directory(fileSystem.path.join('/snap/code/current/', '.vscode')).createSync(recursive: true);
48+
fileSystem.directory(fileSystem.path.join('/snap/code/current/usr/share/code', '.vscode')).createSync(recursive: true);
4949

5050
final FakeProcessManager processManager = FakeProcessManager.list(<FakeCommand>[]);
5151

0 commit comments

Comments
 (0)