Skip to content

Commit 148e86c

Browse files
gmackallGray Mackall
andauthored
Verify the existence of debug symbols in gradle_plugin_bundle_test (#162645)
A small piece of flutter/flutter#162464 that I wanted to land anyways. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md Co-authored-by: Gray Mackall <[email protected]>
1 parent 65124c5 commit 148e86c

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

dev/devicelab/bin/tasks/gradle_plugin_bundle_test.dart

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,8 @@ Future<void> main() async {
3939
'base/lib/arm64-v8a/libflutter.so',
4040
'base/lib/armeabi-v7a/libapp.so',
4141
'base/lib/armeabi-v7a/libflutter.so',
42+
'BUNDLE-METADATA/com.android.tools.build.debugsymbols/arm64-v8a/libflutter.so.sym',
43+
'BUNDLE-METADATA/com.android.tools.build.debugsymbols/armeabi-v7a/libflutter.so.sym',
4244
], await getFilesInAppBundle(releaseBundle));
4345
});
4446

@@ -72,6 +74,8 @@ Future<void> main() async {
7274
'base/lib/arm64-v8a/libflutter.so',
7375
'base/lib/armeabi-v7a/libapp.so',
7476
'base/lib/armeabi-v7a/libflutter.so',
77+
'BUNDLE-METADATA/com.android.tools.build.debugsymbols/arm64-v8a/libflutter.so.sym',
78+
'BUNDLE-METADATA/com.android.tools.build.debugsymbols/armeabi-v7a/libflutter.so.sym',
7579
], await getFilesInAppBundle(bundleFromGradlePath));
7680

7781
section('Build app bundle using the flutter tool - flavor: flavor_underscore');
@@ -103,6 +107,8 @@ Future<void> main() async {
103107
'base/lib/arm64-v8a/libflutter.so',
104108
'base/lib/armeabi-v7a/libapp.so',
105109
'base/lib/armeabi-v7a/libflutter.so',
110+
'BUNDLE-METADATA/com.android.tools.build.debugsymbols/arm64-v8a/libflutter.so.sym',
111+
'BUNDLE-METADATA/com.android.tools.build.debugsymbols/armeabi-v7a/libflutter.so.sym',
106112
], await getFilesInAppBundle(flavorUnderscoreBundlePath));
107113

108114
section('Build app bundle using the flutter tool - flavor: production');
@@ -134,6 +140,8 @@ Future<void> main() async {
134140
'base/lib/arm64-v8a/libflutter.so',
135141
'base/lib/armeabi-v7a/libapp.so',
136142
'base/lib/armeabi-v7a/libflutter.so',
143+
'BUNDLE-METADATA/com.android.tools.build.debugsymbols/arm64-v8a/libflutter.so.sym',
144+
'BUNDLE-METADATA/com.android.tools.build.debugsymbols/armeabi-v7a/libflutter.so.sym',
137145
], await getFilesInAppBundle(productionBundlePath));
138146
});
139147

0 commit comments

Comments
 (0)