Skip to content

Commit 29827d7

Browse files
Update gen_keycodes output to new engine location. (#162479)
The engine is now part of Flutter and doesn't need to have the path configured. The current code doesn't update the engine.
1 parent 9438fd4 commit 29827d7

File tree

2 files changed

+1
-15
lines changed

2 files changed

+1
-15
lines changed

dev/tools/gen_keycodes/README.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,6 @@ anew before generating the files. To do this, run:
3838
This will generate `physical_key_data.g.json` and `logical_key_data.g.json`. These
3939
files should be checked in.
4040

41-
By default this tool assumes that the gclient directory for flutter/engine
42-
and the root for the flutter/flutter are placed at the same folder. If not,
43-
use `--engine-root=/ENGINE/GCLIENT/ROOT` to specify the engine root.
44-
4541
Other options can be found using `--help`.
4642

4743
## Key ID Scheme

dev/tools/gen_keycodes/bin/gen_keycodes.dart

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -111,16 +111,6 @@ Future<void> main(List<String> rawArguments) async {
111111
return;
112112
}
113113
final ArgParser argParser = ArgParser();
114-
argParser.addOption(
115-
'engine-root',
116-
defaultsTo: path.join(flutterRoot.path, '..', 'engine', 'src', 'flutter'),
117-
help:
118-
'The path to the root of the flutter/engine repository. This is used '
119-
'to place the generated engine mapping files. If --engine-root is not '
120-
r'specified, it will default to $flutterRoot/../engine/src/flutter, '
121-
'assuming the engine gclient folder is placed at the same folder as '
122-
'the flutter/flutter repository.',
123-
);
124114
argParser.addOption(
125115
'physical-data',
126116
defaultsTo: path.join(dataRoot, 'physical_key_data.g.json'),
@@ -193,7 +183,7 @@ Future<void> main(List<String> rawArguments) async {
193183
exit(0);
194184
}
195185

196-
PlatformCodeGenerator.engineRoot = parsedArguments['engine-root'] as String;
186+
PlatformCodeGenerator.engineRoot = path.join(flutterRoot.path, 'engine', 'src', 'flutter');
197187

198188
PhysicalKeyData physicalData;
199189
LogicalKeyData logicalData;

0 commit comments

Comments
 (0)