Skip to content

Commit 57890e5

Browse files
authored
Stop running module_test_ios in devicelab and x64 Macs (#148264)
As of flutter/flutter#147934 `module_test_ios` is passing on non-devicelab machines. Remove the devicelab build and mark the arm non-devicelab build as not flaky. @vashworth's summary from flutter/flutter#112033 (comment): > So I believe [the idea](flutter/flutter#141910) was to move `Mac_arm64_ios module_test_ios` to `Mac_arm64 module_test_ios` so it doesn't run on a devicelab bot. > > However, it fails when running on a chromium bot due to a `Trying to load an unsigned library` issue, even though it's using a simulator: > https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.staging/Mac_arm64%20module_test_ios > > It's unclear why, but it seemed that removing the [lines](flutter/flutter#112033 (comment)) that force disabling of codesigning allowed it to run. [@godofredoc was going to do a follow up PR to fix it](flutter/flutter#141910 (comment)), but it was probably forgotten. Also remove the x64 version of this test, since there's nothing arch-specific going on here and it happens to be flaky due to an infrastructure issues. Fixes flutter/flutter#112033 Fixes flutter/flutter#144680
1 parent 39651e8 commit 57890e5

File tree

1 file changed

+0
-33
lines changed

1 file changed

+0
-33
lines changed

.ci.yaml

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -3864,27 +3864,8 @@ targets:
38643864
- bin/**
38653865
- .ci.yaml
38663866

3867-
- name: Mac_x64 module_test_ios
3868-
bringup: true # Flaky https://github.com/flutter/flutter/issues/144680
3869-
recipe: devicelab/devicelab_drone
3870-
timeout: 60
3871-
properties:
3872-
dependencies: >-
3873-
[
3874-
{"dependency": "ruby", "version": "ruby_3.1-pod_1.13"}
3875-
]
3876-
tags: >
3877-
["devicelab", "hostonly", "mac"]
3878-
task_name: module_test_ios
3879-
runIf:
3880-
- dev/**
3881-
- packages/flutter_tools/**
3882-
- bin/**
3883-
- .ci.yaml
3884-
38853867
- name: Mac_arm64 module_test_ios
38863868
recipe: devicelab/devicelab_drone
3887-
bringup: true
38883869
timeout: 60
38893870
properties:
38903871
dependencies: >-
@@ -3900,20 +3881,6 @@ targets:
39003881
- bin/**
39013882
- .ci.yaml
39023883

3903-
- name: Mac_arm64_ios module_test_ios # Must be run on devicelab bot for codesigning https://github.com/flutter/flutter/issues/112033
3904-
recipe: devicelab/devicelab_drone
3905-
presubmit: false
3906-
timeout: 60
3907-
properties:
3908-
tags: >
3909-
["devicelab", "ios", "mac", "arm64"]
3910-
task_name: module_test_ios
3911-
runIf:
3912-
- dev/**
3913-
- packages/flutter_tools/**
3914-
- bin/**
3915-
- .ci.yaml
3916-
39173884
- name: Mac_benchmark platform_view_macos__start_up
39183885
presubmit: false
39193886
recipe: devicelab/devicelab_drone

0 commit comments

Comments
 (0)