Define testWidgetsWithLeakTracking. (#125063)

Author: polina-c

packages/flutter/test/animation/animation_sheet_test.dart

@@ -16,6 +16,8 @@ void main() {
    * because [matchesGoldenFile] does not use Skia Gold in its native package.
    */
 
+  // TODO(polina-c): fix ValueNotifier not disposed and switch to testWidgetsWithLeakTracking.
+  // https://github.com/flutter/devtools/issues/3951
   testWidgets('correctly records frames using display', (WidgetTester tester) async {
     final AnimationSheetBuilder builder = AnimationSheetBuilder(frameSize: _DecuplePixels.size);
 
@@ -52,6 +54,8 @@ void main() {
     await expectLater(find.byWidget(display), matchesGoldenFile('test.animation_sheet_builder.records.png'));
   }, skip: isBrowser); // https://github.com/flutter/flutter/issues/56001
 
+  // TODO(polina-c): fix ValueNotifier not disposed and switch to testWidgetsWithLeakTracking.
+  // https://github.com/flutter/devtools/issues/3951
   testWidgets('correctly wraps a row', (WidgetTester tester) async {
     final AnimationSheetBuilder builder = AnimationSheetBuilder(frameSize: _DecuplePixels.size);
 
@@ -70,6 +74,8 @@ void main() {
     await expectLater(find.byWidget(display), matchesGoldenFile('test.animation_sheet_builder.wraps.png'));
   }, skip: isBrowser); // https://github.com/flutter/flutter/issues/56001
 
+  // TODO(polina-c): fix Picture and Image not disposed and and switch to testWidgetsWithLeakTracking.
+  // https://github.com/flutter/devtools/issues/3951
   testWidgets('correctly records frames using collate', (WidgetTester tester) async {
     final AnimationSheetBuilder builder = AnimationSheetBuilder(frameSize: _DecuplePixels.size);
 
@@ -104,6 +110,8 @@ void main() {
     );
   }, skip: isBrowser); // https://github.com/flutter/flutter/issues/56001
 
+  // TODO(polina-c): fix Picture and Image not disposed and switch to testWidgetsWithLeakTracking.
+  // https://github.com/flutter/devtools/issues/3951
   testWidgets('use allLayers to record out-of-subtree contents', (WidgetTester tester) async {
     final AnimationSheetBuilder builder = AnimationSheetBuilder(
       frameSize: const Size(8, 2),

packages/flutter/test/animation/futures_test.dart

@@ -6,8 +6,10 @@ import 'package:flutter/animation.dart';
 import 'package:flutter/widgets.dart';
 import 'package:flutter_test/flutter_test.dart';
 
+import '../foundation/leak_tracking.dart';
+
 void main() {
-  testWidgets('awaiting animation controllers - using direct future', (WidgetTester tester) async {
+  testWidgetsWithLeakTracking('awaiting animation controllers - using direct future', (WidgetTester tester) async {
     final AnimationController controller1 = AnimationController(
       duration: const Duration(milliseconds: 100),
       vsync: const TestVSync(),
@@ -56,7 +58,7 @@ void main() {
     expect(log, <String>['start', 'a', 'b', 'c', 'd', 'end']);
   });
 
-  testWidgets('awaiting animation controllers - using orCancel', (WidgetTester tester) async {
+  testWidgetsWithLeakTracking('awaiting animation controllers - using orCancel', (WidgetTester tester) async {
     final AnimationController controller1 = AnimationController(
       duration: const Duration(milliseconds: 100),
       vsync: const TestVSync(),
@@ -105,7 +107,7 @@ void main() {
     expect(log, <String>['start', 'a', 'b', 'c', 'd', 'end']);
   });
 
-  testWidgets('awaiting animation controllers and failing', (WidgetTester tester) async {
+  testWidgetsWithLeakTracking('awaiting animation controllers and failing', (WidgetTester tester) async {
     final AnimationController controller1 = AnimationController(
       duration: const Duration(milliseconds: 100),
       vsync: const TestVSync(),
@@ -133,7 +135,7 @@ void main() {
     expect(log, <String>['start', 'caught', 'end']);
   });
 
-  testWidgets('creating orCancel future later', (WidgetTester tester) async {
+  testWidgetsWithLeakTracking('creating orCancel future later', (WidgetTester tester) async {
     final AnimationController controller1 = AnimationController(
       duration: const Duration(milliseconds: 100),
       vsync: const TestVSync(),
@@ -146,7 +148,7 @@ void main() {
     expect(true, isTrue); // should reach here
   });
 
-  testWidgets('creating orCancel future later', (WidgetTester tester) async {
+  testWidgetsWithLeakTracking('creating orCancel future later', (WidgetTester tester) async {
     final AnimationController controller1 = AnimationController(
       duration: const Duration(milliseconds: 100),
       vsync: const TestVSync(),
@@ -163,7 +165,7 @@ void main() {
     expect(ok, isTrue); // should reach here
   });
 
-  testWidgets('TickerFuture is a Future', (WidgetTester tester) async {
+  testWidgetsWithLeakTracking('TickerFuture is a Future', (WidgetTester tester) async {
     final AnimationController controller1 = AnimationController(
       duration: const Duration(milliseconds: 100),
       vsync: const TestVSync(),

packages/flutter/test/animation/iteration_patterns_test.dart

@@ -5,6 +5,8 @@
 import 'package:flutter/widgets.dart';
 import 'package:flutter_test/flutter_test.dart';
 
+import '../foundation/leak_tracking.dart';
+
 void main() {
   setUp(() {
     WidgetsFlutterBinding.ensureInitialized();
@@ -79,7 +81,7 @@ void main() {
     controller.dispose();
   });
 
-  testWidgets('AnimationController with throwing listener', (WidgetTester tester) async {
+  testWidgetsWithLeakTracking('AnimationController with throwing listener', (WidgetTester tester) async {
     final AnimationController controller = AnimationController(
       duration: const Duration(milliseconds: 100),
       vsync: const TestVSync(),
@@ -102,7 +104,7 @@ void main() {
     log.clear();
   });
 
-  testWidgets('AnimationController with throwing status listener', (WidgetTester tester) async {
+  testWidgetsWithLeakTracking('AnimationController with throwing status listener', (WidgetTester tester) async {
     final AnimationController controller = AnimationController(
       duration: const Duration(milliseconds: 100),
       vsync: const TestVSync(),

packages/flutter/test/animation/live_binding_test.dart

@@ -10,6 +10,8 @@ library;
 import 'package:flutter/material.dart';
 import 'package:flutter_test/flutter_test.dart';
 
+import '../foundation/leak_tracking.dart';
+
 void main() {
   /*
    * Here lies golden tests for packages/flutter_test/lib/src/binding.dart
@@ -18,7 +20,7 @@ void main() {
 
   LiveTestWidgetsFlutterBinding().framePolicy = LiveTestWidgetsFlutterBindingFramePolicy.onlyPumps;
 
-  testWidgets('Should show event indicator for pointer events', (WidgetTester tester) async {
+  testWidgetsWithLeakTracking('Should show event indicator for pointer events', (WidgetTester tester) async {
     final AnimationSheetBuilder animationSheet = AnimationSheetBuilder(frameSize: const Size(200, 200), allLayers: true);
     final List<Offset> taps = <Offset>[];
     Widget target({bool recording = true}) => Container(
@@ -76,6 +78,8 @@ void main() {
     // Currently skipped due to daily flake: https://github.com/flutter/flutter/issues/87588
   }, skip: true); // Typically skip: isBrowser https://github.com/flutter/flutter/issues/42767
 
+  // TODO(polina-c): fix ValueNotifier not disposed and switch to testWidgetsWithLeakTracking.
+  // https://github.com/flutter/devtools/issues/3951
   testWidgets('Should show event indicator for pointer events with setSurfaceSize', (WidgetTester tester) async {
     final AnimationSheetBuilder animationSheet = AnimationSheetBuilder(frameSize: const Size(200, 200), allLayers: true);
     final List<Offset> taps = <Offset>[];

packages/flutter/test/flutter_test_config.dart

@@ -6,10 +6,14 @@ import 'dart:async';
 
 import 'package:flutter/rendering.dart';
 import 'package:flutter_test/flutter_test.dart';
+import 'package:leak_tracker/leak_tracker.dart';
 
 import '_goldens_io.dart'
   if (dart.library.html) '_goldens_web.dart' as flutter_goldens;
 
+/// Test configuration for each test library in this directory.
+///
+/// See https://api.flutter.dev/flutter/flutter_test/flutter_test-library.html.
 Future<void> testExecutable(FutureOr<void> Function() testMain) {
   // Enable checks because there are many implementations of [RenderBox] in this
   // package can benefit from the additional validations.
@@ -19,6 +23,8 @@ Future<void> testExecutable(FutureOr<void> Function() testMain) {
   // receive the event.
   WidgetController.hitTestWarningShouldBeFatal = true;
 
+  LeakTrackingTestConfig.warnForNonSupportedPlatforms = false;
+
   // Enable golden file testing using Skia Gold.
   return flutter_goldens.testExecutable(testMain);
 }

packages/flutter/test/foundation/change_notifier_test.dart

@@ -5,6 +5,8 @@
 import 'package:flutter/foundation.dart';
 import 'package:flutter_test/flutter_test.dart';
 
+import 'leak_tracking.dart';
+
 class TestNotifier extends ChangeNotifier {
   void notify() {
     notifyListeners();
@@ -49,23 +51,25 @@ class Counter with ChangeNotifier {
 }
 
 void main() {
-  testWidgets('ChangeNotifier can not dispose in callback', (WidgetTester tester) async {
+  testWidgetsWithLeakTracking('ChangeNotifier can not dispose in callback', (WidgetTester tester) async {
     final TestNotifier test = TestNotifier();
     bool callbackDidFinish = false;
     void foo() {
       test.dispose();
       callbackDidFinish = true;
     }
-
     test.addListener(foo);
+
     test.notify();
+
     final AssertionError error = tester.takeException() as AssertionError;
     expect(error.toString().contains('dispose()'), isTrue);
     // Make sure it crashes during dispose call.
     expect(callbackDidFinish, isFalse);
+    test.dispose();
   });
 
-  testWidgets('ChangeNotifier', (WidgetTester tester) async {
+  testWidgetsWithLeakTracking('ChangeNotifier', (WidgetTester tester) async {
     final List<String> log = <String>[];
     void listener() {
       log.add('listener');
@@ -147,6 +151,7 @@ void main() {
     expect(log, <String>['badListener', 'listener1', 'listener2']);
     expect(tester.takeException(), isArgumentError);
     log.clear();
+    test.dispose();
   });
 
   test('ChangeNotifier with mutating listener', () {