Skip to content

Commit 67170b1

Browse files
authored
[leak-tracking] Add leak tracking in test/painting flutter#1 (#136167)
1 parent 3df6078 commit 67170b1

File tree

5 files changed

+19
-15
lines changed

5 files changed

+19
-15
lines changed

packages/flutter/test/painting/_network_image_test_web.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,17 +6,17 @@ import 'package:flutter/foundation.dart';
66
import 'package:flutter/material.dart';
77
import 'package:flutter/src/painting/_network_image_web.dart';
88
import 'package:flutter_test/flutter_test.dart';
9+
import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';
910
import 'package:web/web.dart' as web;
1011

1112
import '../image_data.dart';
1213
import '_test_http_request.dart';
13-
1414
void runTests() {
1515
tearDown(() {
1616
debugRestoreHttpRequestFactory();
1717
});
1818

19-
testWidgets('loads an image from the network with headers',
19+
testWidgetsWithLeakTracking('loads an image from the network with headers',
2020
(WidgetTester tester) async {
2121
final TestHttpRequest testHttpRequest = TestHttpRequest()
2222
..status = 200
@@ -42,7 +42,7 @@ void runTests() {
4242
assert(mapEquals(testHttpRequest.responseHeaders, headers), true);
4343
});
4444

45-
testWidgets('loads an image from the network with unsuccessful HTTP code',
45+
testWidgetsWithLeakTracking('loads an image from the network with unsuccessful HTTP code',
4646
(WidgetTester tester) async {
4747
final TestHttpRequest testHttpRequest = TestHttpRequest()
4848
..status = 404
@@ -67,7 +67,7 @@ void runTests() {
6767
expect((tester.takeException() as web.ProgressEvent).type, 'test error');
6868
});
6969

70-
testWidgets('loads an image from the network with empty response',
70+
testWidgetsWithLeakTracking('loads an image from the network with empty response',
7171
(WidgetTester tester) async {
7272
final TestHttpRequest testHttpRequest = TestHttpRequest()
7373
..status = 200

packages/flutter/test/painting/binding_test.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,12 @@ import 'package:flutter/scheduler.dart';
1010
import 'package:flutter/services.dart';
1111
import 'package:flutter/widgets.dart';
1212
import 'package:flutter_test/flutter_test.dart';
13+
import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';
1314

1415
Future<void> main() async {
1516
final ui.Image image = await createTestImage();
1617

17-
testWidgets('didHaveMemoryPressure clears imageCache', (WidgetTester tester) async {
18+
testWidgetsWithLeakTracking('didHaveMemoryPressure clears imageCache', (WidgetTester tester) async {
1819
imageCache.putIfAbsent(1, () => OneFrameImageStreamCompleter(
1920
Future<ImageInfo>.value(ImageInfo(
2021
image: image,

packages/flutter/test/painting/border_test.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
import 'package:flutter/widgets.dart';
66
import 'package:flutter_test/flutter_test.dart';
7+
import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';
78

89
class TestCanvas implements Canvas {
910
final List<Invocation> invocations = <Invocation>[];
@@ -316,7 +317,7 @@ void main() {
316317
expect(nonUniformBorderDirectional.dimensions, const EdgeInsetsDirectional.fromSTEB(5, 5, 0, 20));
317318
});
318319

319-
testWidgets('Non-Uniform Border variations', (WidgetTester tester) async {
320+
testWidgetsWithLeakTracking('Non-Uniform Border variations', (WidgetTester tester) async {
320321

321322
Widget buildWidget({ required BoxBorder border, BorderRadius? borderRadius, BoxShape boxShape = BoxShape.rectangle}) {
322323
return Directionality(

packages/flutter/test/painting/box_painter_test.dart

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ library;
99

1010
import 'package:flutter/material.dart';
1111
import 'package:flutter_test/flutter_test.dart';
12+
import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';
1213

1314
void main() {
1415
tearDown(() {
@@ -160,7 +161,7 @@ void main() {
160161
expect(const BoxShadow(blurRadius: 4.0, blurStyle: BlurStyle.solid).toString(), equals('BoxShadow(Color(0xff000000), Offset(0.0, 0.0), 4.0, 0.0, BlurStyle.solid)'));
161162
});
162163

163-
testWidgets('BoxShadow BoxStyle.solid', (WidgetTester tester) async {
164+
testWidgetsWithLeakTracking('BoxShadow BoxStyle.solid', (WidgetTester tester) async {
164165
final Key key = UniqueKey();
165166
debugDisableShadows = false;
166167
await tester.pumpWidget(
@@ -192,7 +193,7 @@ void main() {
192193
debugDisableShadows = true;
193194
});
194195

195-
testWidgets('BoxShadow BoxStyle.outer', (WidgetTester tester) async {
196+
testWidgetsWithLeakTracking('BoxShadow BoxStyle.outer', (WidgetTester tester) async {
196197
final Key key = UniqueKey();
197198
debugDisableShadows = false;
198199
await tester.pumpWidget(
@@ -224,7 +225,7 @@ void main() {
224225
debugDisableShadows = true;
225226
});
226227

227-
testWidgets('BoxShadow BoxStyle.inner', (WidgetTester tester) async {
228+
testWidgetsWithLeakTracking('BoxShadow BoxStyle.inner', (WidgetTester tester) async {
228229
final Key key = UniqueKey();
229230
debugDisableShadows = false;
230231
await tester.pumpWidget(
@@ -256,7 +257,7 @@ void main() {
256257
debugDisableShadows = true;
257258
});
258259

259-
testWidgets('BoxShadow BoxStyle.normal', (WidgetTester tester) async {
260+
testWidgetsWithLeakTracking('BoxShadow BoxStyle.normal', (WidgetTester tester) async {
260261
final Key key = UniqueKey();
261262
debugDisableShadows = false;
262263
await tester.pumpWidget(
@@ -288,7 +289,7 @@ void main() {
288289
debugDisableShadows = true;
289290
});
290291

291-
testWidgets('BoxShadow BoxStyle.normal.wide_radius', (WidgetTester tester) async {
292+
testWidgetsWithLeakTracking('BoxShadow BoxStyle.normal.wide_radius', (WidgetTester tester) async {
292293
final Key key = UniqueKey();
293294
debugDisableShadows = false;
294295
await tester.pumpWidget(
@@ -321,7 +322,7 @@ void main() {
321322
debugDisableShadows = true;
322323
});
323324

324-
testWidgets('BoxShadow BoxStyle.outer.wide_radius', (WidgetTester tester) async {
325+
testWidgetsWithLeakTracking('BoxShadow BoxStyle.outer.wide_radius', (WidgetTester tester) async {
325326
final Key key = UniqueKey();
326327
debugDisableShadows = false;
327328
await tester.pumpWidget(
@@ -354,7 +355,7 @@ void main() {
354355
debugDisableShadows = true;
355356
});
356357

357-
testWidgets('BoxShadow BoxStyle.solid.wide_radius', (WidgetTester tester) async {
358+
testWidgetsWithLeakTracking('BoxShadow BoxStyle.solid.wide_radius', (WidgetTester tester) async {
358359
final Key key = UniqueKey();
359360
debugDisableShadows = false;
360361
await tester.pumpWidget(
@@ -386,7 +387,7 @@ void main() {
386387
debugDisableShadows = true;
387388
});
388389

389-
testWidgets('BoxShadow BoxStyle.inner.wide_radius', (WidgetTester tester) async {
390+
testWidgetsWithLeakTracking('BoxShadow BoxStyle.inner.wide_radius', (WidgetTester tester) async {
390391
final Key key = UniqueKey();
391392
debugDisableShadows = false;
392393
await tester.pumpWidget(

packages/flutter/test/painting/flutter_logo_test.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ library;
99

1010
import 'package:flutter/widgets.dart';
1111
import 'package:flutter_test/flutter_test.dart';
12+
import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';
1213

1314
void main() {
1415
// Here and below, see: https://github.com/dart-lang/sdk/issues/26980
@@ -85,7 +86,7 @@ void main() {
8586
);
8687
});
8788

88-
testWidgets('Flutter Logo golden test', (WidgetTester tester) async {
89+
testWidgetsWithLeakTracking('Flutter Logo golden test', (WidgetTester tester) async {
8990
final Key logo = UniqueKey();
9091
await tester.pumpWidget(Container(
9192
key: logo,

0 commit comments

Comments
 (0)