Skip to content

Commit cbe2698

Browse files
authored
Enable duplicate linux_host_engine_test. (#161613)
Towards flutter/flutter#161406. * Enables (on presubmit), and adds a missing GN target. * Removes tests from the `linux_host_engine` build.
1 parent 3f2b7d9 commit cbe2698

File tree

2 files changed

+26
-6
lines changed

2 files changed

+26
-6
lines changed

engine/src/flutter/.ci.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -321,8 +321,6 @@ targets:
321321

322322
- name: Linux linux_host_engine_test
323323
recipe: engine_v2/engine_v2
324-
# TODO(matanlurey): https://github.com/flutter/flutter/issues/161406.
325-
bringup: true
326324
timeout: 120
327325
properties:
328326
config_name: linux_host_engine_test

engine/src/flutter/ci/builders/linux_host_engine_test.json

Lines changed: 26 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,10 @@
2929
"ninja": {
3030
"config": "ci/host_debug_test",
3131
"targets": [
32-
"flutter:unittests"
32+
"flutter:unittests",
33+
"flutter/build/dart:copy_dart_sdk",
34+
"flutter/shell/testing",
35+
"flutter/tools/path_ops"
3336
]
3437
},
3538
"tests": [
@@ -73,9 +76,26 @@
7376
"ninja": {
7477
"config": "ci/host_profile_test",
7578
"targets": [
76-
"flutter:unittests"
79+
"flutter:unittests",
80+
"flutter/build/dart:copy_dart_sdk",
81+
"flutter/shell/testing",
82+
"flutter/tools/path_ops"
7783
]
78-
}
84+
},
85+
"tests": [
86+
{
87+
"language": "python3",
88+
"name": "Host Tests for host_profile",
89+
"script": "flutter/testing/run_tests.py",
90+
"parameters": [
91+
"--variant",
92+
"ci/host_profile_test",
93+
"--type",
94+
"dart,dart-host,engine",
95+
"--engine-capture-core-dump"
96+
]
97+
}
98+
]
7999
},
80100
{
81101
"drone_dimensions": [
@@ -109,7 +129,7 @@
109129
"config": "ci/host_release_test",
110130
"targets": [
111131
"flutter:unittests",
112-
"flutter/build/archives:flutter_patched_sdk",
132+
"flutter/build/dart:copy_dart_sdk",
113133
"flutter/display_list:display_list_benchmarks",
114134
"flutter/display_list:display_list_builder_benchmarks",
115135
"flutter/display_list:display_list_region_benchmarks",
@@ -118,6 +138,8 @@
118138
"flutter/impeller/geometry:geometry_benchmarks",
119139
"flutter/lib/ui:ui_benchmarks",
120140
"flutter/shell/common:shell_benchmarks",
141+
"flutter/shell/testing",
142+
"flutter/tools/path_ops",
121143
"flutter/third_party/txt:txt_benchmarks"
122144
]
123145
},

0 commit comments

Comments
 (0)