Dispose ValueNotifier in EditableTextState (#104590)

tgucio · web-flow · commit aa1c43bbde13 · 2022-05-25T13:08:11.000-07:00
diff --git a/packages/flutter/lib/src/widgets/editable_text.dart b/packages/flutter/lib/src/widgets/editable_text.dart
@@ -1953,6 +1953,7 @@ class EditableTextState extends State<EditableText> with AutomaticKeepAliveClien
     WidgetsBinding.instance.removeObserver(this);
     _clipboardStatus?.removeListener(_onChangedClipboardStatus);
     _clipboardStatus?.dispose();
+    _cursorVisibilityNotifier.dispose();
     super.dispose();
     assert(_batchEditDepth <= 0, 'unfinished batch edits: $_batchEditDepth');
   }

Original file line number	Diff line number	Diff line change
`@@ -1953,6 +1953,7 @@ class EditableTextState extends State<EditableText> with AutomaticKeepAliveClien`
`1953`	`1953`	`WidgetsBinding.instance.removeObserver(this);`
`1954`	`1954`	`_clipboardStatus?.removeListener(_onChangedClipboardStatus);`
`1955`	`1955`	`_clipboardStatus?.dispose();`
	`1956`	`+ _cursorVisibilityNotifier.dispose();`
`1956`	`1957`	`super.dispose();`
`1957`	`1958`	`assert(_batchEditDepth <= 0, 'unfinished batch edits: $_batchEditDepth');`
`1958`	`1959`	`}`