Skip to content

Commit c46d4c0

Browse files
author
Jonah Williams
authored
Revert "[framework] Reland: use ImageFilter for zoom page transition " (#102611)
1 parent 936623e commit c46d4c0

2 files changed

Lines changed: 2 additions & 68 deletions

File tree

‎packages/flutter/lib/src/material/page_transitions_theme.dart‎

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -318,11 +318,7 @@ class _ZoomEnterTransition extends StatelessWidget {
318318
},
319319
child: FadeTransition(
320320
opacity: fadeTransition,
321-
child: ScaleTransition(
322-
scale: scaleTransition,
323-
filterQuality: FilterQuality.low,
324-
child: child,
325-
),
321+
child: ScaleTransition(scale: scaleTransition, child: child),
326322
),
327323
);
328324
}
@@ -367,11 +363,7 @@ class _ZoomExitTransition extends StatelessWidget {
367363

368364
return FadeTransition(
369365
opacity: fadeTransition,
370-
child: ScaleTransition(
371-
scale: scaleTransition,
372-
filterQuality: FilterQuality.low,
373-
child: child,
374-
),
366+
child: ScaleTransition(scale: scaleTransition, child: child),
375367
);
376368
}
377369
}

‎packages/flutter/test/material/page_transitions_theme_test.dart‎

Lines changed: 0 additions & 58 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import 'package:flutter/cupertino.dart';
66
import 'package:flutter/foundation.dart';
77
import 'package:flutter/material.dart';
8-
import 'package:flutter/rendering.dart';
98
import 'package:flutter_test/flutter_test.dart';
109

1110
void main() {
@@ -221,61 +220,4 @@ void main() {
221220
await tester.pumpAndSettle();
222221
expect(builtCount, 1);
223222
}, variant: TargetPlatformVariant.only(TargetPlatform.android));
224-
225-
testWidgets('_ZoomPageTransition uses a FilterQuality while animating', (WidgetTester tester) async {
226-
final Map<String, WidgetBuilder> routes = <String, WidgetBuilder>{
227-
'/': (BuildContext context) => Material(
228-
child: TextButton(
229-
child: const Text('push'),
230-
onPressed: () { Navigator.of(context).pushNamed('/b'); },
231-
),
232-
),
233-
'/b': (BuildContext context) => StatefulBuilder(
234-
builder: (BuildContext context, StateSetter setState) {
235-
return TextButton(
236-
child: const Text('pop'),
237-
onPressed: () { Navigator.pop(context); },
238-
);
239-
},
240-
),
241-
};
242-
243-
await tester.pumpWidget(
244-
MaterialApp(
245-
theme: ThemeData(
246-
pageTransitionsTheme: const PageTransitionsTheme(
247-
builders: <TargetPlatform, PageTransitionsBuilder>{
248-
TargetPlatform.android: ZoomPageTransitionsBuilder(), // creates a _ZoomPageTransition
249-
},
250-
),
251-
),
252-
routes: routes,
253-
),
254-
);
255-
256-
expect(tester.layers, isNot(contains(isA<ImageFilterLayer>())));
257-
258-
await tester.tap(find.text('push'));
259-
await tester.pump();
260-
await tester.pump();
261-
262-
expect(tester.layers, contains(isA<ImageFilterLayer>()));
263-
expect(tester.layers.whereType<ImageFilterLayer>(), hasLength(1));
264-
265-
await tester.pumpAndSettle();
266-
267-
expect(tester.layers, isNot(contains(isA<ImageFilterLayer>())));
268-
269-
await tester.tap(find.text('pop'));
270-
await tester.pump();
271-
await tester.pump();
272-
273-
expect(tester.layers, contains(isA<ImageFilterLayer>()));
274-
// exiting requires two different zooms.
275-
expect(tester.layers.whereType<ImageFilterLayer>(), hasLength(2));
276-
277-
await tester.pumpAndSettle();
278-
279-
expect(tester.layers, isNot(contains(isA<ImageFilterLayer>())));
280-
}, variant: TargetPlatformVariant.only(TargetPlatform.android));
281223
}

0 commit comments

Comments
 (0)