workaround for pytest marker stains bug pytest-dev/pytest#568

Author: enthusiastdev121

zarr/tests/test_convenience.py

@@ -579,42 +579,38 @@ def test_logging(self):
     h5py = None
 
 
-def temp_h5f():
-    fn = tempfile.mktemp()
-    atexit.register(os.remove, fn)
-    h5f = h5py.File(fn, mode='w')
-    atexit.register(lambda v: v.close(), h5f)
-    return h5f
+if h5py is not None:
 
-
-@pytest.mark.skipif(h5py is None, reason='h5py not installed')
-class TestCopyHDF5ToZarr(TestCopy):
-
-    def __init__(self, *args, **kwargs):
-        super(TestCopyHDF5ToZarr, self).__init__(*args, **kwargs)
-        self.source_h5py = True
-        self.dest_h5py = False
-        self.new_source = temp_h5f
-        self.new_dest = group
-
-
-@pytest.mark.skipif(h5py is None, reason='h5py not installed')
-class TestCopyZarrToHDF5(TestCopy):
-
-    def __init__(self, *args, **kwargs):
-        super(TestCopyZarrToHDF5, self).__init__(*args, **kwargs)
-        self.source_h5py = False
-        self.dest_h5py = True
-        self.new_source = group
-        self.new_dest = temp_h5f
-
-
-@pytest.mark.skipif(h5py is None, reason='h5py not installed')
-class TestCopyHDF5ToHDF5(TestCopy):
-
-    def __init__(self, *args, **kwargs):
-        super(TestCopyHDF5ToHDF5, self).__init__(*args, **kwargs)
-        self.source_h5py = True
-        self.dest_h5py = True
-        self.new_source = temp_h5f
-        self.new_dest = temp_h5f
+    def temp_h5f():
+        fn = tempfile.mktemp()
+        atexit.register(os.remove, fn)
+        h5f = h5py.File(fn, mode='w')
+        atexit.register(lambda v: v.close(), h5f)
+        return h5f
+
+    class TestCopyHDF5ToZarr(TestCopy):
+
+        def __init__(self, *args, **kwargs):
+            super(TestCopyHDF5ToZarr, self).__init__(*args, **kwargs)
+            self.source_h5py = True
+            self.dest_h5py = False
+            self.new_source = temp_h5f
+            self.new_dest = group
+
+    class TestCopyZarrToHDF5(TestCopy):
+
+        def __init__(self, *args, **kwargs):
+            super(TestCopyZarrToHDF5, self).__init__(*args, **kwargs)
+            self.source_h5py = False
+            self.dest_h5py = True
+            self.new_source = group
+            self.new_dest = temp_h5f
+
+    class TestCopyHDF5ToHDF5(TestCopy):
+
+        def __init__(self, *args, **kwargs):
+            super(TestCopyHDF5ToHDF5, self).__init__(*args, **kwargs)
+            self.source_h5py = True
+            self.dest_h5py = True
+            self.new_source = temp_h5f
+            self.new_dest = temp_h5f

zarr/tests/test_core.py

@@ -1251,23 +1251,24 @@ def test_nbytes_stored(self):
     bsddb3 = None
 
 
-@pytest.mark.skipif(bsddb3 is None, reason='bsddb3 not installed')
-class TestArrayWithDBMStoreBerkeleyDB(TestArray):
+if bsddb3 is not None:
 
-    @staticmethod
-    def create_array(read_only=False, **kwargs):
-        path = mktemp(suffix='.dbm')
-        atexit.register(os.remove, path)
-        store = DBMStore(path, flag='n', open=bsddb3.btopen)
-        cache_metadata = kwargs.pop('cache_metadata', True)
-        cache_attrs = kwargs.pop('cache_attrs', True)
-        kwargs.setdefault('compressor', Zlib(1))
-        init_array(store, **kwargs)
-        return Array(store, read_only=read_only, cache_metadata=cache_metadata,
-                     cache_attrs=cache_attrs)
+    class TestArrayWithDBMStoreBerkeleyDB(TestArray):
 
-    def test_nbytes_stored(self):
-        pass  # not implemented
+        @staticmethod
+        def create_array(read_only=False, **kwargs):
+            path = mktemp(suffix='.dbm')
+            atexit.register(os.remove, path)
+            store = DBMStore(path, flag='n', open=bsddb3.btopen)
+            cache_metadata = kwargs.pop('cache_metadata', True)
+            cache_attrs = kwargs.pop('cache_attrs', True)
+            kwargs.setdefault('compressor', Zlib(1))
+            init_array(store, **kwargs)
+            return Array(store, read_only=read_only, cache_metadata=cache_metadata,
+                         cache_attrs=cache_attrs)
+
+        def test_nbytes_stored(self):
+            pass  # not implemented
 
 
 try:
@@ -1276,42 +1277,41 @@ def test_nbytes_stored(self):
     lmdb = None
 
 
-@pytest.mark.skipif(lmdb is None, reason='lmdb is not installed')
-class TestArrayWithLMDBStore(TestArray):
+if lmdb is not None:
 
-    @staticmethod
-    def create_array(read_only=False, **kwargs):
-        path = mktemp(suffix='.lmdb')
-        atexit.register(atexit_rmtree, path)
-        store = LMDBStore(path, buffers=True)
-        cache_metadata = kwargs.pop('cache_metadata', True)
-        cache_attrs = kwargs.pop('cache_attrs', True)
-        kwargs.setdefault('compressor', Zlib(1))
-        init_array(store, **kwargs)
-        return Array(store, read_only=read_only, cache_metadata=cache_metadata,
-                     cache_attrs=cache_attrs)
+    class TestArrayWithLMDBStore(TestArray):
 
-    def test_nbytes_stored(self):
-        pass  # not implemented
+        @staticmethod
+        def create_array(read_only=False, **kwargs):
+            path = mktemp(suffix='.lmdb')
+            atexit.register(atexit_rmtree, path)
+            store = LMDBStore(path, buffers=True)
+            cache_metadata = kwargs.pop('cache_metadata', True)
+            cache_attrs = kwargs.pop('cache_attrs', True)
+            kwargs.setdefault('compressor', Zlib(1))
+            init_array(store, **kwargs)
+            return Array(store, read_only=read_only, cache_metadata=cache_metadata,
+                         cache_attrs=cache_attrs)
 
+        def test_nbytes_stored(self):
+            pass  # not implemented
 
-@pytest.mark.skipif(lmdb is None, reason='lmdb is not installed')
-class TestArrayWithLMDBStoreNoBuffers(TestArray):
+    class TestArrayWithLMDBStoreNoBuffers(TestArray):
 
-    @staticmethod
-    def create_array(read_only=False, **kwargs):
-        path = mktemp(suffix='.lmdb')
-        atexit.register(atexit_rmtree, path)
-        store = LMDBStore(path, buffers=False)
-        cache_metadata = kwargs.pop('cache_metadata', True)
-        cache_attrs = kwargs.pop('cache_attrs', True)
-        kwargs.setdefault('compressor', Zlib(1))
-        init_array(store, **kwargs)
-        return Array(store, read_only=read_only, cache_metadata=cache_metadata,
-                     cache_attrs=cache_attrs)
+        @staticmethod
+        def create_array(read_only=False, **kwargs):
+            path = mktemp(suffix='.lmdb')
+            atexit.register(atexit_rmtree, path)
+            store = LMDBStore(path, buffers=False)
+            cache_metadata = kwargs.pop('cache_metadata', True)
+            cache_attrs = kwargs.pop('cache_attrs', True)
+            kwargs.setdefault('compressor', Zlib(1))
+            init_array(store, **kwargs)
+            return Array(store, read_only=read_only, cache_metadata=cache_metadata,
+                         cache_attrs=cache_attrs)
 
-    def test_nbytes_stored(self):
-        pass  # not implemented
+        def test_nbytes_stored(self):
+            pass  # not implemented
 
 
 class TestArrayWithNoCompressor(TestArray):

zarr/tests/test_hierarchy.py

@@ -892,15 +892,16 @@ def create_store():
     bsddb3 = None
 
 
-@pytest.mark.skipif(bsddb3 is None, reason='bsddb3 is not installed')
-class TestGroupWithDBMStoreBerkeleyDB(TestGroup):
+if bsddb3 is not None:
 
-    @staticmethod
-    def create_store():
-        path = tempfile.mktemp(suffix='.dbm')
-        atexit.register(os.remove, path)
-        store = DBMStore(path, flag='n', open=bsddb3.btopen)
-        return store, None
+    class TestGroupWithDBMStoreBerkeleyDB(TestGroup):
+
+        @staticmethod
+        def create_store():
+            path = tempfile.mktemp(suffix='.dbm')
+            atexit.register(os.remove, path)
+            store = DBMStore(path, flag='n', open=bsddb3.btopen)
+            return store, None
 
 
 try:
@@ -909,15 +910,16 @@ def create_store():
     lmdb = None
 
 
-@pytest.mark.skipif(lmdb is None, reason='lmdb is not installed')
-class TestGroupWithLMDBStore(TestGroup):
+if lmdb is not None:
 
-    @staticmethod
-    def create_store():
-        path = tempfile.mktemp(suffix='.lmdb')
-        atexit.register(atexit_rmtree, path)
-        store = LMDBStore(path)
-        return store, None
+    class TestGroupWithLMDBStore(TestGroup):
+
+        @staticmethod
+        def create_store():
+            path = tempfile.mktemp(suffix='.lmdb')
+            atexit.register(atexit_rmtree, path)
+            store = LMDBStore(path)
+            return store, None
 
 
 class TestGroupWithChunkStore(TestGroup):

zarr/tests/test_storage.py

@@ -777,14 +777,15 @@ def create_store(self):
     gdbm = None
 
 
-@pytest.mark.skipif(gdbm is None, reason='gdbm is not installed')
-class TestDBMStoreGnu(TestDBMStore):
+if gdbm is not None:
 
-    def create_store(self):
-        path = tempfile.mktemp(suffix='.gdbm')
-        atexit.register(os.remove, path)
-        store = DBMStore(path, flag='n', open=gdbm.open, write_lock=False)
-        return store
+    class TestDBMStoreGnu(TestDBMStore):
+
+        def create_store(self):
+            path = tempfile.mktemp(suffix='.gdbm')
+            atexit.register(os.remove, path)
+            store = DBMStore(path, flag='n', open=gdbm.open, write_lock=False)
+            return store
 
 
 if not PY2:
@@ -793,14 +794,15 @@ def create_store(self):
     except ImportError:  # pragma: no cover
         ndbm = None
 
-    @pytest.mark.skipif(ndbm is None, reason='ndbm is not installed')
-    class TestDBMStoreNDBM(TestDBMStore):
+    if ndbm is not None:
 
-        def create_store(self):
-            path = tempfile.mktemp(suffix='.ndbm')
-            atexit.register(atexit_rmglob, path + '*')
-            store = DBMStore(path, flag='n', open=ndbm.open)
-            return store
+        class TestDBMStoreNDBM(TestDBMStore):
+
+            def create_store(self):
+                path = tempfile.mktemp(suffix='.ndbm')
+                atexit.register(atexit_rmglob, path + '*')
+                store = DBMStore(path, flag='n', open=ndbm.open)
+                return store
 
 
 try:
@@ -809,14 +811,15 @@ def create_store(self):
     bsddb3 = None
 
 
-@pytest.mark.skipif(bsddb3 is None, reason='bsddb3 is not installed')
-class TestDBMStoreBerkeleyDB(TestDBMStore):
+if bsddb3 is not None:
 
-    def create_store(self):
-        path = tempfile.mktemp(suffix='.dbm')
-        atexit.register(os.remove, path)
-        store = DBMStore(path, flag='n', open=bsddb3.btopen, write_lock=False)
-        return store
+    class TestDBMStoreBerkeleyDB(TestDBMStore):
+
+        def create_store(self):
+            path = tempfile.mktemp(suffix='.dbm')
+            atexit.register(os.remove, path)
+            store = DBMStore(path, flag='n', open=bsddb3.btopen, write_lock=False)
+            return store
 
 
 try:
@@ -825,26 +828,27 @@ def create_store(self):
     lmdb = None
 
 
-@pytest.mark.skipif(lmdb is None, reason='lmdb is not installed')
-class TestLMDBStore(StoreTests, unittest.TestCase):
+if lmdb is not None:
 
-    def create_store(self):
-        path = tempfile.mktemp(suffix='.lmdb')
-        atexit.register(atexit_rmtree, path)
-        if PY2:  # pragma: py3 no cover
-            # don't use buffers, otherwise would have to rewrite tests as bytes and
-            # buffer don't compare equal in PY2
-            buffers = False
-        else:  # pragma: py2 no cover
-            buffers = True
-        store = LMDBStore(path, buffers=buffers)
-        return store
+    class TestLMDBStore(StoreTests, unittest.TestCase):
 
-    def test_context_manager(self):
-        with self.create_store() as store:
-            store['foo'] = b'bar'
-            store['baz'] = b'qux'
-            assert 2 == len(store)
+        def create_store(self):
+            path = tempfile.mktemp(suffix='.lmdb')
+            atexit.register(atexit_rmtree, path)
+            if PY2:  # pragma: py3 no cover
+                # don't use buffers, otherwise would have to rewrite tests as bytes and
+                # buffer don't compare equal in PY2
+                buffers = False
+            else:  # pragma: py2 no cover
+                buffers = True
+            store = LMDBStore(path, buffers=buffers)
+            return store
+
+        def test_context_manager(self):
+            with self.create_store() as store:
+                store['foo'] = b'bar'
+                store['baz'] = b'qux'
+                assert 2 == len(store)
 
 
 class TestLRUStoreCache(StoreTests, unittest.TestCase):