Skip to content

Commit 788c295

Browse files
committed
ci: Disable wasm coverage tests (#24169)
and adjust-coverage-total Signed-off-by: Ryan Northey <[email protected]> Signed-off-by: phlax <[email protected]>
1 parent b45b1e1 commit 788c295

File tree

3 files changed

+19
-7
lines changed

3 files changed

+19
-7
lines changed

bazel/envoy_select.bzl

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,9 @@ def envoy_select_wasm_cpp_tests(xs):
6565
def envoy_select_wasm_rust_tests(xs):
6666
return select({
6767
"@envoy//bazel:wasm_disabled": [],
68+
# TODO(phlax): re-enable once issues with llvm profiler are resolved
69+
# (see https://github.com/envoyproxy/envoy/issues/24164)
70+
"@envoy//bazel:coverage_build": [],
6871
"//conditions:default": xs,
6972
})
7073

@@ -76,6 +79,9 @@ def envoy_select_wasm_v8(xs):
7679
"@envoy//bazel:wasm_wasmtime": [],
7780
"@envoy//bazel:wasm_wavm": [],
7881
"@envoy//bazel:wasm_disabled": [],
82+
# TODO(phlax): re-enable once issues with llvm profiler are resolved
83+
# (see https://github.com/envoyproxy/envoy/issues/24164)
84+
"@envoy//bazel:coverage_build": [],
7985
"//conditions:default": xs, # implicit default (v8)
8086
})
8187

@@ -87,6 +93,9 @@ def envoy_select_wasm_v8_bool():
8793
"@envoy//bazel:wasm_wasmtime": False,
8894
"@envoy//bazel:wasm_wavm": False,
8995
"@envoy//bazel:wasm_disabled": False,
96+
# TODO(phlax): re-enable once issues with llvm profiler are resolved
97+
# (see https://github.com/envoyproxy/envoy/issues/24164)
98+
"@envoy//bazel:coverage_build": False,
9099
"//conditions:default": True, # implicit default (v8)
91100
})
92101

test/per_file_coverage.sh

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ declare -a KNOWN_LOW_COVERAGE=(
88
"source/common/api/posix:81.3"
99
"source/common/common:96.2"
1010
"source/common/common/posix:92.7"
11-
"source/common/config:96.5"
11+
"source/common/config:96.4"
1212
"source/common/crypto:0.0"
1313
"source/common/event:94.1" # Emulated edge events guards don't report LCOV
1414
"source/common/filesystem/posix:95.5"
@@ -33,9 +33,11 @@ declare -a KNOWN_LOW_COVERAGE=(
3333
"source/common/upstream:96.0"
3434
"source/common/watchdog:58.6" # Death tests don't report LCOV
3535
"source/exe:92.6"
36-
"source/extensions/common:95.8"
37-
"source/extensions/common/tap:92.9"
38-
"source/extensions/common/wasm:94.7" # flaky: be careful adjusting
36+
"source/extensions/access_loggers/wasm:93.0"
37+
"source/extensions/clusters/common:68.2"
38+
"source/extensions/common:92.4"
39+
"source/extensions/common/tap:92.4"
40+
"source/extensions/common/wasm:87.5" # flaky: be careful adjusting
3941
"source/extensions/common/wasm/ext:92.0"
4042
"source/extensions/filters/common:96.1"
4143
"source/extensions/filters/common/expr:96.2"
@@ -50,7 +52,7 @@ declare -a KNOWN_LOW_COVERAGE=(
5052
"source/extensions/filters/http/kill_request:91.7" # Death tests don't report LCOV
5153
"source/extensions/filters/http/lua:96.4"
5254
"source/extensions/filters/http/oauth2:96.0"
53-
"source/extensions/filters/http/wasm:95.8"
55+
"source/extensions/filters/http/wasm:1.9"
5456
"source/extensions/filters/listener:95.9"
5557
"source/extensions/filters/listener/http_inspector:95.8"
5658
"source/extensions/filters/listener/original_dst:82.4"
@@ -62,7 +64,8 @@ declare -a KNOWN_LOW_COVERAGE=(
6264
"source/extensions/filters/network/sni_cluster:88.9"
6365
"source/extensions/filters/network/sni_dynamic_forward_proxy:95.2"
6466
"source/extensions/filters/network/thrift_proxy/router:96.4"
65-
"source/extensions/filters/network/wasm:95.7"
67+
"source/extensions/filters/network/thrift_proxy/filters/payload_to_metadata:96.2"
68+
"source/extensions/filters/network/wasm:76.9"
6669
"source/extensions/filters/udp:96.4"
6770
"source/extensions/filters/udp/dns_filter:96.1"
6871
"source/extensions/health_checkers:95.7"

test/run_envoy_bazel_coverage.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ fi
2828
[[ -z "${SRCDIR}" ]] && SRCDIR="${PWD}"
2929
[[ -z "${VALIDATE_COVERAGE}" ]] && VALIDATE_COVERAGE=true
3030
[[ -z "${FUZZ_COVERAGE}" ]] && FUZZ_COVERAGE=false
31-
[[ -z "${COVERAGE_THRESHOLD}" ]] && COVERAGE_THRESHOLD=96.2
31+
[[ -z "${COVERAGE_THRESHOLD}" ]] && COVERAGE_THRESHOLD=96.1
3232
COVERAGE_TARGET="${COVERAGE_TARGET:-}"
3333
read -ra BAZEL_BUILD_OPTIONS <<< "${BAZEL_BUILD_OPTIONS:-}"
3434

0 commit comments

Comments
 (0)