Skip to content

deps: bump com_github_wasmtime -> 1.0.0 #23232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

RiverPhillips
Copy link
Contributor

Commit Message: deps: bump com_github_wasmtime -> 1.0.0
Additional Description: Resolves #23193
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: river phillips <[email protected]>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Sep 23, 2022
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @mattklein123

🐱

Caused by: #23232 was opened by RiverPhillips.

see: more, trace.

@phlax
Copy link
Member

phlax commented Sep 23, 2022

cc @kfaseela

@moderation
Copy link
Contributor

/lgtm deps

This looks like it is passing without some of the normal adjacent dependency updates

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Sep 24, 2022
@mattklein123 mattklein123 merged commit 0c6de85 into envoyproxy:main Sep 26, 2022
@phlax
Copy link
Member

phlax commented Sep 26, 2022

This looks like it is passing without some of the normal adjacent dependency updates

not sure it that is cause for concern cc @PiotrSikora

@PiotrSikora
Copy link
Contributor

Wasmtime (well, it's Bazel rules) is tracked and updated in Proxy-Wasm C++ Host. The only thing updated in this PR are the C API files used in bazel/external/wasmtime.BUILD, but @proxy_wasm_cpp_host//bazel/cargo/wasmtime dependency there still points at Wasmtime v0.39.1.

Tests passed, because the C API didn't change between v0.39.1 and v1.0.0, but this PR didn't update Wasmtime.

It might be worth documenting this somewhere in bazel/repository_locations.bzl. cc @mpwarres

@kfaseela
Copy link
Contributor

@RiverPhillips Will you be interested in pushing the corresponding PR in Proxy-Wasm C++ Host ? Some info on how to do the update can be seen at proxy-wasm/proxy-wasm-cpp-host#194 (comment)

@RiverPhillips
Copy link
Contributor Author

Sure @kfaseela will have a look

phlax pushed a commit to phlax/envoy that referenced this pull request Nov 19, 2022
Signed-off-by: river phillips <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
phlax pushed a commit that referenced this pull request Nov 21, 2022
Signed-off-by: river phillips <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
phlax pushed a commit to phlax/envoy that referenced this pull request Nov 23, 2022
Signed-off-by: river phillips <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
phlax pushed a commit to phlax/envoy that referenced this pull request Nov 23, 2022
Signed-off-by: river phillips <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
phlax added a commit that referenced this pull request Nov 30, 2022
…24089)

* deps: bump `com_github_wasmtime` -> 1.0.0 (#23232)

Signed-off-by: river phillips <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>

* wasm: update WAVM to nightly/2022-05-14. (#22491)


Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>

* wasm: update Proxy-Wasm C++ Host to latest. (#22575)

Signed-off-by: Piotr Sikora <[email protected]>

Signed-off-by: Ryan Northey <[email protected]>

* deps: Bump `com_github_wasmtime` -> 1.0.2 (#24086)

Fix:

- CVE-2022-39392
- CVE-2022-39393
- CVE-2022-39394

Signed-off-by: Ryan Northey <[email protected]>

* bazel: update rules_rust

This gets us on rust 1.60

Signed-off-by: Keith Smiley <[email protected]>

Signed-off-by: Ryan Northey <[email protected]>

* deps: Bump `rules_rust` -> 0.8.1 (#22253)

Fix #22073

Signed-off-by: Ryan Northey <[email protected]>

* wasm: fix V8 build on older versions of Linux. (#22228)

wasm: fix build on older versions of Linux.

Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>

* backport: macOS: Allow to load .wasm on Apple silicon (#23299)

backport: macOS: Enable wasm and allow to load .wasm on Apple silicon

This applies https://chromium-review.googlesource.com/c/v8/v8/+/3700352 as a fix for
MemoryAllocator::PartialFreeMemory() which shouldn't try to change permissions of RWX pages.

This mainly affects macOS > 11.2 due to mprotect behavior changes (#23243)
on Apple silicon.

This is cherry-picked from: 63f27a6

Signed-off-by: Dhi Aurrahman <[email protected]>

Signed-off-by: Dhi Aurrahman <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>

* deps: Bump `v8` to 10.7.193.13 and `proxy_wasm_cpp_host` to b0a0594 (#23434)

Signed-off-by: Dhi Aurrahman <[email protected]>

* ci: Disable wasm coverage tests (#24169)

and adjust-coverage-total

Signed-off-by: Ryan Northey <[email protected]>

Signed-off-by: phlax <[email protected]>

* deps: Bump `com_github_wasmtime` -> 2.0.2 (+related) (#24150)

deps: Bump `com_github_wasmtime` -> 2.0.2

- `proxy_wasm_cpp_host`
- `proxy_wasm_rust_sdk`

Signed-off-by: Ryan Northey <[email protected]>

Signed-off-by: river phillips <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Dhi Aurrahman <[email protected]>
Signed-off-by: phlax <[email protected]>
Co-authored-by: River <[email protected]>
Co-authored-by: Piotr Sikora <[email protected]>
Co-authored-by: Keith Smiley <[email protected]>
Co-authored-by: Dhi Aurrahman <[email protected]>
phlax pushed a commit that referenced this pull request Dec 3, 2022
Signed-off-by: river phillips <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Newer release available com_github_wasmtime: v1.0.0 (current: v0.39.1)
6 participants