fix #1107 #1111
Merged
fix #1107 #1111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Took some review suggestions from @daurnimator:
|
DanielOaks
reviewed
Jun 4, 2020
docs/MANUAL.md
Outdated
| * `certfp`: during certfp-based authentication, this is a string, otherwise omitted | ||
| * `ip`: a string representation of the client's IP address | ||
|
|
||
| The script must print a single line (`\n`-terminated) to its output and exit. This line must be a JSON-encoded dictionary with the following keys: |
Member
There was a problem hiding this comment.
maybe we could replace "JSON-encoded dictionary" with "JSON dictionary"? seeing the -encoded part made me double-take and have to think about what was meant for a few seconds~
Member
|
This is super cool, exciting~ |
slingamn
added a commit
to slingamn/ergo
that referenced
this pull request
Jun 4, 2020
This was referenced Jun 4, 2020
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.