ci: fix Windows build after PR 2874 (#2876)

canepat · web-flow · commit 7fcccf2780c9 · 2025-04-25T02:36:42.000+02:00
diff --git a/silkworm/sync/sync_pos_test.cpp b/silkworm/sync/sync_pos_test.cpp
@@ -116,7 +116,7 @@ TEST_CASE_METHOD(PoSSyncTest, "PoSSync::new_payload.get_header_timeout", "[sync]
                     co_return BlockHeader{};
                 }));
 
-            CHECK(spawn_and_wait(sync_.new_payload(request, 1ms)).status == rpc::PayloadStatus::kSyncingStr);
+            CHECK(spawn_and_wait(sync_.new_payload(request, 1ms)).status == std::string{rpc::PayloadStatus::kSyncingStr});
         }
     }
 }
@@ -137,7 +137,7 @@ TEST_CASE_METHOD(PoSSyncTest, "PoSSync::new_payload.get_td_timeout", "[sync]") {
                     co_return kSepoliaConfig.terminal_total_difficulty;
                 }));
 
-            CHECK(spawn_and_wait(sync_.new_payload(request, 1ms)).status == rpc::PayloadStatus::kSyncingStr);
+            CHECK(spawn_and_wait(sync_.new_payload(request, 1ms)).status == std::string{rpc::PayloadStatus::kSyncingStr});
         }
     }
 }
@@ -162,7 +162,7 @@ TEST_CASE_METHOD(PoSSyncTest, "PoSSync::new_payload.insert_blocks_timeout", "[sy
                     co_return execution::api::InsertionResult{};
                 }));
 
-            CHECK(spawn_and_wait(sync_.new_payload(request, 1ms)).status == rpc::PayloadStatus::kSyncingStr);
+            CHECK(spawn_and_wait(sync_.new_payload(request, 1ms)).status == std::string{rpc::PayloadStatus::kSyncingStr});
         }
     }
 }
@@ -191,7 +191,7 @@ TEST_CASE_METHOD(PoSSyncTest, "PoSSync::new_payload.get_header_hash_number_timeo
                     co_return payload.block_num;
                 }));
 
-            CHECK(spawn_and_wait(sync_.new_payload(request, 1ms)).status == rpc::PayloadStatus::kSyncingStr);
+            CHECK(spawn_and_wait(sync_.new_payload(request, 1ms)).status == std::string{rpc::PayloadStatus::kSyncingStr});
         }
     }
 }
@@ -250,7 +250,7 @@ TEST_CASE_METHOD(PoSSyncTest, "PoSSync::new_payload.validate_chain_success", "[s
                     co_return execution::api::ValidChain{};
                 }));
 
-            CHECK(spawn_and_wait(sync_.new_payload(request, 1ms)).status == rpc::PayloadStatus::kValidStr);
+            CHECK(spawn_and_wait(sync_.new_payload(request, 1ms)).status == std::string{rpc::PayloadStatus::kValidStr});
         }
     }
 }
@@ -265,7 +265,7 @@ static const rpc::ForkChoiceUpdatedRequest kInvalidForkChoiceUpdatedRequest{
 
 TEST_CASE_METHOD(PoSSyncTest, "PoSSync::fork_choice_updated.invalid_request", "[sync]") {
     const auto request = kInvalidForkChoiceUpdatedRequest;
-    CHECK(spawn_and_wait(sync_.fork_choice_updated(request, 1ms)).payload_status.status == rpc::PayloadStatus::kInvalidStr);
+    CHECK(spawn_and_wait(sync_.fork_choice_updated(request, 1ms)).payload_status.status == std::string{rpc::PayloadStatus::kInvalidStr});
 }
 
 static const rpc::ForkChoiceUpdatedRequest kValidForkChoiceUpdatedRequest{
@@ -286,7 +286,7 @@ TEST_CASE_METHOD(PoSSyncTest, "PoSSync::fork_choice_updated.get_header1_timeout"
             co_return BlockHeader{};
         }));
 
-    CHECK(spawn_and_wait(sync_.fork_choice_updated(request, 1ms)).payload_status.status == rpc::PayloadStatus::kSyncingStr);
+    CHECK(spawn_and_wait(sync_.fork_choice_updated(request, 1ms)).payload_status.status == std::string{rpc::PayloadStatus::kSyncingStr});
 }
 
 TEST_CASE_METHOD(PoSSyncTest, "PoSSync::fork_choice_updated.get_header2_timeout", "[sync]") {
@@ -304,7 +304,7 @@ TEST_CASE_METHOD(PoSSyncTest, "PoSSync::fork_choice_updated.get_header2_timeout"
             co_return BlockHeader{};
         }));
 
-    CHECK(spawn_and_wait(sync_.fork_choice_updated(request, 1ms)).payload_status.status == rpc::PayloadStatus::kSyncingStr);
+    CHECK(spawn_and_wait(sync_.fork_choice_updated(request, 1ms)).payload_status.status == std::string{rpc::PayloadStatus::kSyncingStr});
 }
 
 }  // namespace silkworm::chainsync

Original file line number	Diff line number	Diff line change
`@@ -116,7 +116,7 @@ TEST_CASE_METHOD(PoSSyncTest, "PoSSync::new_payload.get_header_timeout", "[sync]`
`116`	`116`	`co_return BlockHeader{};`
`117`	`117`	`}));`
`118`	`118`
`119`		`- CHECK(spawn_and_wait(sync_.new_payload(request, 1ms)).status == rpc::PayloadStatus::kSyncingStr);`
	`119`	`+ CHECK(spawn_and_wait(sync_.new_payload(request, 1ms)).status == std::string{rpc::PayloadStatus::kSyncingStr});`
`120`	`120`	`}`
`121`	`121`	`}`
`122`	`122`	`}`
`@@ -137,7 +137,7 @@ TEST_CASE_METHOD(PoSSyncTest, "PoSSync::new_payload.get_td_timeout", "[sync]") {`
`137`	`137`	`co_return kSepoliaConfig.terminal_total_difficulty;`
`138`	`138`	`}));`
`139`	`139`
`140`		`- CHECK(spawn_and_wait(sync_.new_payload(request, 1ms)).status == rpc::PayloadStatus::kSyncingStr);`
	`140`	`+ CHECK(spawn_and_wait(sync_.new_payload(request, 1ms)).status == std::string{rpc::PayloadStatus::kSyncingStr});`
`141`	`141`	`}`
`142`	`142`	`}`
`143`	`143`	`}`
`@@ -162,7 +162,7 @@ TEST_CASE_METHOD(PoSSyncTest, "PoSSync::new_payload.insert_blocks_timeout", "[sy`
`162`	`162`	`co_return execution::api::InsertionResult{};`
`163`	`163`	`}));`
`164`	`164`
`165`		`- CHECK(spawn_and_wait(sync_.new_payload(request, 1ms)).status == rpc::PayloadStatus::kSyncingStr);`
	`165`	`+ CHECK(spawn_and_wait(sync_.new_payload(request, 1ms)).status == std::string{rpc::PayloadStatus::kSyncingStr});`
`166`	`166`	`}`
`167`	`167`	`}`
`168`	`168`	`}`
`@@ -191,7 +191,7 @@ TEST_CASE_METHOD(PoSSyncTest, "PoSSync::new_payload.get_header_hash_number_timeo`
`191`	`191`	`co_return payload.block_num;`
`192`	`192`	`}));`
`193`	`193`
`194`		`- CHECK(spawn_and_wait(sync_.new_payload(request, 1ms)).status == rpc::PayloadStatus::kSyncingStr);`
	`194`	`+ CHECK(spawn_and_wait(sync_.new_payload(request, 1ms)).status == std::string{rpc::PayloadStatus::kSyncingStr});`
`195`	`195`	`}`
`196`	`196`	`}`
`197`	`197`	`}`
`@@ -250,7 +250,7 @@ TEST_CASE_METHOD(PoSSyncTest, "PoSSync::new_payload.validate_chain_success", "[s`
`250`	`250`	`co_return execution::api::ValidChain{};`
`251`	`251`	`}));`
`252`	`252`
`253`		`- CHECK(spawn_and_wait(sync_.new_payload(request, 1ms)).status == rpc::PayloadStatus::kValidStr);`
	`253`	`+ CHECK(spawn_and_wait(sync_.new_payload(request, 1ms)).status == std::string{rpc::PayloadStatus::kValidStr});`
`254`	`254`	`}`
`255`	`255`	`}`
`256`	`256`	`}`
`@@ -265,7 +265,7 @@ static const rpc::ForkChoiceUpdatedRequest kInvalidForkChoiceUpdatedRequest{`
`265`	`265`
`266`	`266`	`TEST_CASE_METHOD(PoSSyncTest, "PoSSync::fork_choice_updated.invalid_request", "[sync]") {`
`267`	`267`	`const auto request = kInvalidForkChoiceUpdatedRequest;`
`268`		`- CHECK(spawn_and_wait(sync_.fork_choice_updated(request, 1ms)).payload_status.status == rpc::PayloadStatus::kInvalidStr);`
	`268`	`+ CHECK(spawn_and_wait(sync_.fork_choice_updated(request, 1ms)).payload_status.status == std::string{rpc::PayloadStatus::kInvalidStr});`
`269`	`269`	`}`
`270`	`270`
`271`	`271`	`static const rpc::ForkChoiceUpdatedRequest kValidForkChoiceUpdatedRequest{`
`@@ -286,7 +286,7 @@ TEST_CASE_METHOD(PoSSyncTest, "PoSSync::fork_choice_updated.get_header1_timeout"`
`286`	`286`	`co_return BlockHeader{};`
`287`	`287`	`}));`
`288`	`288`
`289`		`- CHECK(spawn_and_wait(sync_.fork_choice_updated(request, 1ms)).payload_status.status == rpc::PayloadStatus::kSyncingStr);`
	`289`	`+ CHECK(spawn_and_wait(sync_.fork_choice_updated(request, 1ms)).payload_status.status == std::string{rpc::PayloadStatus::kSyncingStr});`
`290`	`290`	`}`
`291`	`291`
`292`	`292`	`TEST_CASE_METHOD(PoSSyncTest, "PoSSync::fork_choice_updated.get_header2_timeout", "[sync]") {`
`@@ -304,7 +304,7 @@ TEST_CASE_METHOD(PoSSyncTest, "PoSSync::fork_choice_updated.get_header2_timeout"`
`304`	`304`	`co_return BlockHeader{};`
`305`	`305`	`}));`
`306`	`306`
`307`		`- CHECK(spawn_and_wait(sync_.fork_choice_updated(request, 1ms)).payload_status.status == rpc::PayloadStatus::kSyncingStr);`
	`307`	`+ CHECK(spawn_and_wait(sync_.fork_choice_updated(request, 1ms)).payload_status.status == std::string{rpc::PayloadStatus::kSyncingStr});`
`308`	`308`	`}`
`309`	`309`
`310`	`310`	`} // namespace silkworm::chainsync`