feat(no-unused-disable): deprecate rule#299
Merged
Merged
Conversation
MichaelDeBoey
force-pushed
the
deprecate-no-unused-disable-rule
branch
2 times, most recently
from
b616eb5 to
9654b3d
Compare
MichaelDeBoey
force-pushed
the
deprecate-no-unused-disable-rule
branch
from
9654b3d to
7ee19f4
Compare
JoshuaKGoldberg
approved these changes
Jan 14, 2026
JoshuaKGoldberg
left a comment
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
IMO the sooner it's deprecated the better. Deprecation is not a breaking change.
|
🎉 This PR is included in version 4.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@eslint-community/eslint-plugin-eslint-comments Do we want to deprecate this rule in a minor release or do we include the deprecation in the next major release (which will also drop ESLint v6 & v7 support) and only remove it in the major release after that?