fix: address ci failures (#578)

* fix: fix type errors in rules

* fix: address incompat between eslint-scope and eslint types

* chore: update eslint packages

* test: add console log to try and triage CI failures

* chore: update typescript-eslint

* test: correct projectService value

* build: pin typescript-eslint

Author: michaelfaith

lib/rules/no-property-in-node.ts

@@ -1,4 +1,5 @@
 import type { Rule } from 'eslint';
+import type { BinaryExpression } from 'estree';
 import type { Type } from 'typescript';
 
 const defaultTypedNodeSourceFileTesters = [
@@ -90,7 +91,7 @@ const rule: Rule.RuleModule = {
     ];
 
     return {
-      'BinaryExpression[operator=in]'(node) {
+      'BinaryExpression[operator=in]'(node: BinaryExpression) {
         // TODO: Switch this to ESLintUtils.getParserServices with typescript-eslint@>=6
         // https://github.com/eslint-community/eslint-plugin-eslint-plugin/issues/269
         const services = context.sourceCode.parserServices;

lib/rules/prefer-replace-text.ts

@@ -3,7 +3,7 @@
  * @author 薛定谔的猫<hh_2013@foxmail.com>
  */
 import type { Rule } from 'eslint';
-import type { Identifier, Node } from 'estree';
+import type { CallExpression, Identifier, Node } from 'estree';
 
 import type { FunctionInfo } from '../types.ts';
 import {
@@ -70,17 +70,18 @@ const rule: Rule.RuleModule = {
       },
 
       // Checks the replaceTextRange arguments.
-      'CallExpression[arguments.length=2]'(node) {
+      'CallExpression[arguments.length=2]'(node: CallExpression) {
         if (
           funcInfo.shouldCheck &&
           node.callee.type === 'MemberExpression' &&
+          node.callee.property.type === 'Identifier' &&
           node.callee.property.name === 'replaceTextRange'
         ) {
           const arg = node.arguments[0];
           const isIdenticalNodeRange =
             arg.type === 'ArrayExpression' &&
-            arg.elements[0].type === 'MemberExpression' &&
-            arg.elements[1].type === 'MemberExpression' &&
+            arg.elements[0]?.type === 'MemberExpression' &&
+            arg.elements[1]?.type === 'MemberExpression' &&
             sourceCode.getText(arg.elements[0].object) ===
               sourceCode.getText(arg.elements[1].object);
           if (isIdenticalNodeRange) {

package.json

@@ -54,27 +54,28 @@
     "@commitlint/types": "^19.8.1",
     "@eslint-community/eslint-plugin-eslint-comments": "^4.3.0",
     "@eslint/eslintrc": "^3.0.2",
-    "@eslint/js": "^9.31.0",
+    "@eslint/js": "^9.39.1",
     "@types/eslint-plugin-markdown": "^2.0.2",
-    "@types/eslint-scope": "^8.3.0",
     "@types/espree": "^10.1.0",
+    "@types/esrecurse": "^4.3.1",
     "@types/estraverse": "^5.1.7",
     "@types/estree": "^1.0.8",
     "@types/lodash": "^4.17.18",
     "@types/node": "^20.19.23",
-    "@typescript-eslint/parser": "^8.39.0",
-    "@typescript-eslint/utils": "^8.39.0",
+    "@typescript-eslint/parser": "8.47.0",
+    "@typescript-eslint/utils": "8.47.0",
     "@vitest/coverage-istanbul": "^3.2.4",
-    "eslint": "^9.31.0",
+    "eslint": "^9.39.1",
     "eslint-config-not-an-aardvark": "^2.1.0",
     "eslint-config-prettier": "^10.1.8",
     "eslint-doc-generator": "^2.2.2",
     "eslint-plugin-markdown": "^5.1.0",
     "eslint-plugin-n": "^17.21.0",
     "eslint-plugin-unicorn": "^56.0.1",
     "eslint-remote-tester": "^4.0.3",
-    "eslint-scope": "^8.0.1",
-    "espree": "^10.0.1",
+    "eslint-scope": "^9.0.0",
+    "eslint-visitor-keys": "^5.0.0",
+    "espree": "^11.0.0",
     "husky": "^9.1.7",
     "jiti": "^2.5.1",
     "lodash": "^4.17.21",
@@ -84,7 +85,7 @@
     "prettier": "3.6.2",
     "tsdown": "^0.13.3",
     "typescript": "^5.9.2",
-    "typescript-eslint": "^8.39.0",
+    "typescript-eslint": "8.47.0",
     "vitest": "^3.2.4"
   },
   "peerDependencies": {

tests/lib/rules/no-property-in-node.ts

@@ -9,9 +9,7 @@ const ruleTester = new RuleTester({
   languageOptions: {
     parser,
     parserOptions: {
-      projectService: {
-        defaultProject: 'tsconfig.json',
-      },
+      projectService: true,
       tsconfigRootDir: path.join(dirname, '../fixtures'),
     },
   },

tests/lib/utils.ts

@@ -827,7 +827,10 @@ describe('utils', () => {
         if (typeof caseInfo === 'object' && caseInfo !== null) {
           // Object-style test case used when we need to specify additional information for this test case.
           assert.strictEqual(
-            utils.getKeyName(caseInfo.getNode(ast), scopeManager.globalScope),
+            utils.getKeyName(
+              caseInfo.getNode(ast),
+              scopeManager.globalScope ?? undefined,
+            ),
             caseInfo.result,
           );
 
@@ -846,7 +849,7 @@ describe('utils', () => {
           assert.strictEqual(
             utils.getKeyName(
               expression.properties[0],
-              scopeManager.globalScope,
+              scopeManager.globalScope ?? undefined,
             ),
             caseInfo,
           );

tsconfig.json

@@ -15,9 +15,10 @@
     "forceConsistentCasingInFileNames": true,
     "rewriteRelativeImportExtensions": true,
     "paths": {
-      "eslint-plugin-eslint-plugin": ["./lib/index.ts"]
+      "eslint-plugin-eslint-plugin": ["./lib/index.ts"],
+      "eslint-scope": ["./types/eslint-scope.d.ts"]
     },
-    "types": ["eslint-scope", "espree", "estree", "lodash", "node"]
+    "types": ["espree", "esrecurse", "estree", "lodash", "node"]
   },
   "include": ["lib/**/*", "tests/**/*", "types/**/*"]
 }