-
-
Notifications
You must be signed in to change notification settings - Fork 210
Change Request: Track implicit globals #653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think yes, we should create a global variable declaration in eslint-scope for implicit globals, that's how just JS works. |
Ping @eslint/eslint-team |
I think it shouldn't, for several reasons:
|
I didn't realize these were tracked separately. In that case, I agree, we don't need to make any changes. We should document this in the README for safekeeping. |
Which packages would you like to change?
espree
eslint-scope
eslint-visitor-keys
What problem do you want to solve?
Split off from: eslint/eslint#19695 (comment)
Right now, implicit globals aren't actually treated as globals. Instead, they're treated as unresolved. Example:
That means we aren't able to track implicit globals like we do explicit globals.
What do you think is the correct solution?
We should consider whether assignment to an implicit global should create a global variable declaration in eslint-scope.
Participation
Additional comments
No response
The text was updated successfully, but these errors were encountered: