Skip to content

fix: revert re-export ESM types in CommonJS#427

Merged
DMartens merged 1 commit intomainfrom
revert-pr-416
Apr 8, 2026
Merged

fix: revert re-export ESM types in CommonJS#427
DMartens merged 1 commit intomainfrom
revert-pr-416

Conversation

@fasttime
Copy link
Copy Markdown
Member

@fasttime fasttime commented Apr 8, 2026

This reverts commit ef16f80.

Prerequisites checklist

AI acknowledgment

  • I did not use AI to generate this PR.
  • (If the above is not checked) I have reviewed the AI-generated content before submitting.

What is the purpose of this pull request?

Unblock release eslint/eslint#20670

What changes did you make? (Give an overview)

Revert PR #416 to restore compatibility with TS 7 preview and the named rule of eslint-plugin-import-x.

Related Issues

fixes #425

Is there anything you'd like reviewers to focus on?

@github-project-automation github-project-automation Bot moved this to Needs Triage in Triage Apr 8, 2026
@eslint-github-bot eslint-github-bot Bot added the bug Something isn't working label Apr 8, 2026
@fasttime fasttime moved this from Needs Triage to Implementing in Triage Apr 8, 2026
@fasttime fasttime marked this pull request as ready for review April 8, 2026 08:22
Copy link
Copy Markdown

@DMartens DMartens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thanks.

@DMartens DMartens merged commit 9b16fe1 into main Apr 8, 2026
32 checks passed
@DMartens DMartens deleted the revert-pr-416 branch April 8, 2026 08:57
@github-project-automation github-project-automation Bot moved this from Implementing to Complete in Triage Apr 8, 2026
@eslintbot eslintbot mentioned this pull request Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted bug Something isn't working

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

Bug: Functions are exported as type-only from commonjs export of @eslint/config-helpers

2 participants