ISSUE-274: Report render array output error in Metadata Display preview #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@aksm is still still on the works? Need any help or discussing? |
Contributor
Author
|
@DiegoPino I had a question about error reporting that I can dig back up for our call tomorrow. |
…y used Twig vars and unused JSON keys.
DiegoPino
reviewed
Mar 24, 2023
| */ | ||
| function _format_strawberryfield_metadata_preview_error_handler($error_level, $message, $filename = NULL, $line = NULL, $context = NULL) { | ||
| _drupal_error_handler(E_WARNING, $message, $filename, $line, $context); | ||
| throw new ErrorException($message, $error_level, 0, $filename, $line); |
DiegoPino
reviewed
Mar 24, 2023
| $variables = []; | ||
| foreach ($nodes as $node) { | ||
| if ($node instanceof \Twig_Node_Expression_Name) { | ||
| if ($node instanceof \Twig\Node\Expression\NameExpression) { |
DiegoPino
reviewed
Mar 24, 2023
| * A list of used $variables by this template. | ||
| */ | ||
| private function getTwigVariableNames(ModuleNode $nodes): array { | ||
| private function getTwigVariableNames(ModuleNode|Node|BodyNode $nodes): array { |
Member
There was a problem hiding this comment.
Ohhh.. this is new to me! So cool. So 3 params in the docs but really a single multi type one in the function argument?
DiegoPino
reviewed
Mar 24, 2023
| * AJAX callback. | ||
| */ | ||
| public static function ajaxPreview($form, FormStateInterface $form_state) { | ||
| set_error_handler('_format_strawberryfield_metadata_preview_error_handler'); |
DiegoPino
reviewed
Mar 24, 2023
| ]; | ||
| } | ||
| restore_error_handler(); | ||
| restore_exception_handler(); |
DiegoPino
approved these changes
Mar 29, 2023
Member
DiegoPino
left a comment
DiegoPino
left a comment
There was a problem hiding this comment.
Looks good. Let's work on the next step together. I have high dreams about an JS/Interactive JS driven JSON picker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start on resolving #274 with refactor to the below to replace deprecated classes.
format_strawberryfield/src/Entity/MetadataDisplayEntity.php
Lines 435 to 459 in 2e5cc2a