ISSUE-40: Add Media ordering to All formatters that need it #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which are all. I mean, we need to. This is using @giancarlobi
DiegoPino
added
enhancement
Contributor
|
@DiegoPino looks good, handy use for Base formatter. |
Member
Author
|
@marlo-longley detected after merge some bugs related to the fact that not every formatter extends the base formatter (why not also... i mean could we allow people to set also a IIIF server on the Twig template one... we should) so @giancarlobi this pull was wrong and introduced bugs. Fixing now in a new one |
This was referenced Jan 29, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #40
What are we adding here?
Sequence ordering of our as:media elements everywhere they are used in output/formatters.
This is based on @giancarlobi work on the
::orderPagesmethod. It just extends the same concept to every other formatter and Twig injecting process and moved methods to common classes.@giancarlobi @marlo-longley