Skip to content

Commit ee89921

Browse files
kubalewskianguy11
authored andcommitted
ice: fix pin phase adjust updates on PF reset
Do not allow to set phase adjust value for a pin if PF reset is in progress, this would cause confusing netlink extack errors as the firmware cannot process the request properly during the reset time. Return (-EBUSY) and report extack error for the user who tries configure pin phase adjust during the reset time. Test by looping execution of below steps until netlink error appears: - perform PF reset $ echo 1 > /sys/class/net/<ice PF>/device/reset - change pin phase adjust value: $ ./tools/net/ynl/cli.py --spec Documentation/netlink/specs/dpll.yaml \ --do pin-set --json '{"id":0, "phase-adjust":1000}' Fixes: 90e1c90 ("ice: dpll: implement phase related callbacks") Reviewed-by: Igor Bagnucki <[email protected]> Signed-off-by: Arkadiusz Kubalewski <[email protected]> Tested-by: Pucha Himasekhar Reddy <[email protected]> (A Contingent worker at Intel) Signed-off-by: Tony Nguyen <[email protected]>
1 parent 9a8385f commit ee89921

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

drivers/net/ethernet/intel/ice/ice_dpll.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -963,6 +963,9 @@ ice_dpll_pin_phase_adjust_set(const struct dpll_pin *pin, void *pin_priv,
963963
u8 flag, flags_en = 0;
964964
int ret;
965965

966+
if (ice_dpll_is_reset(pf, extack))
967+
return -EBUSY;
968+
966969
mutex_lock(&pf->dplls.lock);
967970
switch (type) {
968971
case ICE_DPLL_PIN_TYPE_INPUT:

0 commit comments

Comments
 (0)