Skip to content

Commit 34077c0

Browse files
earlephilhowerd-a-v
authored andcommitted
Allow use of LED16 for generic boards (#6343)
Generic boards can have their LEDs on pins 0...16 inclusive, so ensure that the range we generate in boards.txt is inclusive. Fixes #5817
1 parent aecf113 commit 34077c0

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

boards.txt

+4
Original file line numberDiff line numberDiff line change
@@ -365,6 +365,8 @@ generic.menu.led.14=14
365365
generic.menu.led.14.build.led=-DLED_BUILTIN=14
366366
generic.menu.led.15=15
367367
generic.menu.led.15.build.led=-DLED_BUILTIN=15
368+
generic.menu.led.16=16
369+
generic.menu.led.16.build.led=-DLED_BUILTIN=16
368370
generic.menu.sdk.nonosdk222_100=nonos-sdk 2.2.1+100 (testing)
369371
generic.menu.sdk.nonosdk222_100.build.sdk=NONOSDK22y
370372
generic.menu.sdk.nonosdk221=nonos-sdk 2.2.1 (legacy)
@@ -639,6 +641,8 @@ esp8285.menu.led.14=14
639641
esp8285.menu.led.14.build.led=-DLED_BUILTIN=14
640642
esp8285.menu.led.15=15
641643
esp8285.menu.led.15.build.led=-DLED_BUILTIN=15
644+
esp8285.menu.led.16=16
645+
esp8285.menu.led.16.build.led=-DLED_BUILTIN=16
642646
esp8285.menu.ip.lm2f=v2 Lower Memory
643647
esp8285.menu.ip.lm2f.build.lwip_include=lwip2/include
644648
esp8285.menu.ip.lm2f.build.lwip_lib=-llwip2-536-feat

tools/boards.txt.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1327,7 +1327,7 @@ def led (default,max):
13271327
('.menu.led.' + str(default), str(default)),
13281328
('.menu.led.' + str(default) + '.build.led', '-DLED_BUILTIN=' + str(default)),
13291329
]);
1330-
for i in range(0,max):
1330+
for i in range(0,max+1): # Make range incluside of max (16), since there are really 16 GPIOS not 15
13311331
if not i == default:
13321332
led.update(
13331333
collections.OrderedDict([

0 commit comments

Comments
 (0)