SPI: writePattern() should not call setDataBits(0) (#8636)

mcspr · web-flow · commit d44c3f42a39d · 2022-07-27T23:03:01.000+02:00
resolves #8635
diff --git a/libraries/SPI/SPI.cpp b/libraries/SPI/SPI.cpp
@@ -515,9 +515,11 @@ void SPIClass::writePattern(const uint8_t * data, uint8_t size, uint32_t repeat)
         }
     }
     //End orig
-    setDataBits(repeatRem * 8);
-    SPI1CMD |= SPIBUSY;
-    while(SPI1CMD & SPIBUSY) {}
+    if (repeatRem) {
+        setDataBits(repeatRem * 8);
+        SPI1CMD |= SPIBUSY;
+        while(SPI1CMD & SPIBUSY) {}
+    }
 
     SPI1U = SPIUMOSI | SPIUDUPLEX | SPIUSSE;
 }

Original file line number	Diff line number	Diff line change
`@@ -515,9 +515,11 @@ void SPIClass::writePattern(const uint8_t * data, uint8_t size, uint32_t repeat)`
`515`	`515`	`}`
`516`	`516`	`}`
`517`	`517`	`//End orig`
`518`		`- setDataBits(repeatRem * 8);`
`519`		`- SPI1CMD \|= SPIBUSY;`
`520`		`- while(SPI1CMD & SPIBUSY) {}`
	`518`	`+ if (repeatRem) {`
	`519`	`+ setDataBits(repeatRem * 8);`
	`520`	`+ SPI1CMD \|= SPIBUSY;`
	`521`	`+ while(SPI1CMD & SPIBUSY) {}`
	`522`	`+ }`
`521`	`523`
`522`	`524`	`SPI1U = SPIUMOSI \| SPIUDUPLEX \| SPIUSSE;`
`523`	`525`	`}`