Skip to content

Commit d62fb9f

Browse files
mcsprd-a-v
authored andcommitted
MDNS: fix legacy unicast responses (#6613)
* mdns: use ID from parameter struct when constructing response message * print id for legacy requests
1 parent d7abafe commit d62fb9f

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

libraries/ESP8266mDNS/src/LEAmDNS_Control.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ bool MDNSResponder::_parseQuery(const MDNSResponder::stcMDNS_MsgHeader& p_MsgHea
245245
((wifi_get_ip_info(STATION_IF, &IPInfo_Local)) &&
246246
(ip4_addr_netcmp(&IPInfo_Remote.ip, &IPInfo_Local.ip, &IPInfo_Local.netmask))))) { // Remote IP in STATION's subnet
247247

248-
DEBUG_EX_RX(DEBUG_OUTPUT.printf_P(PSTR("[MDNSResponder] _parseQuery: Legacy query from local host %s!\n"), IPAddress(m_pUDPContext->getRemoteAddress()).toString().c_str()););
248+
DEBUG_EX_RX(DEBUG_OUTPUT.printf_P(PSTR("[MDNSResponder] _parseQuery: Legacy query from local host %s, id %u!\n"), IPAddress(m_pUDPContext->getRemoteAddress()).toString().c_str(), p_MsgHeader.m_u16ID););
249249

250250
sendParameter.m_u16ID = p_MsgHeader.m_u16ID;
251251
sendParameter.m_bLegacyQuery = true;

libraries/ESP8266mDNS/src/LEAmDNS_Transfer.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ bool MDNSResponder::_prepareMDNSMessage(MDNSResponder::stcMDNSSendParameter& p_r
141141
bool bResult = true;
142142

143143
// Prepare header; count answers
144-
stcMDNS_MsgHeader msgHeader(0, p_rSendParameter.m_bResponse, 0, p_rSendParameter.m_bAuthorative);
144+
stcMDNS_MsgHeader msgHeader(p_rSendParameter.m_u16ID, p_rSendParameter.m_bResponse, 0, p_rSendParameter.m_bAuthorative);
145145
// If this is a response, the answers are anwers,
146146
// else this is a query or probe and the answers go into auth section
147147
uint16_t& ru16Answers = (p_rSendParameter.m_bResponse

0 commit comments

Comments
 (0)