-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Wrong documentation of WiFiServer::write #5166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Is this function needed, or should we just update the doc ? |
I can see a function like that as being useful but I do not think that should be the default behaviour. I wonder if the comment in that example is correct (for non-ESP8266 devices) or if it was a not quite write description. What if you had two clients connected to the server but loaded with different sub-pages? It can really make a mess of things. But then there is the case of the same web page sending updated status.
This is useful, but it is a specific case, not the default. |
I think, it is not very useful. In deed, I did not expect the existence of such a function. But what ever you the dics should fit to the code. |
Some comments here:
|
It's #2743. |
That's the one, thanks! If someone makes a PR I will review. |
Closed via #6338 |
In https://arduino-esp8266.readthedocs.io/en/latest/esp8266wifi/server-class.html
write()
points to https://www.arduino.cc/en/Reference/WiFiServerWrite. There is written:That is not true for this library. The method is not implemented:
size_t WiFiServer::write(const uint8_t *buffer, size_t size) { // write to all clients // not implemented (void) buffer; (void) size; return 0; }
The text was updated successfully, but these errors were encountered: