Skip to content

Replace noInterrupts/Interrupts with InterruptLock in EEPROM #6589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
6 tasks done
devyte opened this issue Oct 3, 2019 · 0 comments · Fixed by #6599
Closed
6 tasks done

Replace noInterrupts/Interrupts with InterruptLock in EEPROM #6589

devyte opened this issue Oct 3, 2019 · 0 comments · Fixed by #6599

Comments

@devyte
Copy link
Collaborator

devyte commented Oct 3, 2019

Basic Infos

  • This issue complies with the issue POLICY doc.
  • I have read the documentation at readthedocs and the issue is not addressed there.
  • I have tested that the issue is present in current master branch (aka latest git).
  • I have searched the issue tracker for a similar issue.
  • If there is a stack dump, I have decoded it.
  • I have filled out all fields below.

Platform

  • Hardware: All
  • Core Version: latest git today
  • Development Env: All
  • Operating System: All

Problem Description

EEPROM class is using noInterrupts/interrupts, and there is an spi operation in between. Thisnusage doesn't allow nesting, and it blindly disables/enables all interrupts without regard for previous state.

Replace with scoped InterruptLock class.

@devyte devyte self-assigned this Oct 3, 2019
@devyte devyte added this to the 2.6.0 milestone Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant